This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Add 'github' project type to factory-plugin #450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
requested review from
l0rd,
olexii4,
rhopp,
sunix,
vitaliy-guliy and
vparfonov
as code owners
September 26, 2019 09:40
l0rd
approved these changes
Sep 26, 2019
AndrienkoAleksandr
approved these changes
Sep 26, 2019
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
@l0rd seems for WsAgent and GWT IDE github project type meant that OAuth authentication should be done if there is 403 issue during try to clone a project. |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
Can someone explain the logic of this change? Is this a real bug eclipse-che/che#14668, or we just forget some unknow functionality? |
olexii4
approved these changes
Sep 26, 2019
dmytro-ndp
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com
What does this PR do?
Adds missed project type to factory plugin.
What issues does this PR fix or reference?
fix eclipse-che/che#14668