Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add 'github' project type to factory-plugin #450

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

akurinnoy
Copy link
Contributor

Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com

What does this PR do?

Adds missed project type to factory plugin.

What issues does this PR fix or reference?

fix eclipse-che/che#14668

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@sleshchenko
Copy link
Member

@l0rd seems for WsAgent and GWT IDE github project type meant that OAuth authentication should be done if there is 403 issue during try to clone a project.
Do you know if we plan to implement the same for Theia? Maybe we already have it but I did not catch.

@che-bot
Copy link
Contributor

che-bot commented Sep 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@skabashnyuk
Copy link

Can someone explain the logic of this change? Is this a real bug eclipse-che/che#14668, or we just forget some unknow functionality?

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was tested locally and the problem looked been resolved:
Selection_055

@akurinnoy akurinnoy merged commit 71951be into master Sep 26, 2019
@akurinnoy akurinnoy deleted the factory-plugin-gh-type branch September 26, 2019 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project type "github" is not supported by factory plugin
8 participants