Use theia-plugin-ext from node_modules. #464
Conversation
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
l0rd,
rhopp and
vparfonov
as code owners
|
ci-build-check |
|
I know why you're doing that but you could say in description that it's required as relative paths are not working when using nexe or pkg when trying to build single executable file, etc. |
|
ci-build-check |
|
ci-build |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
@benoitf happy path passed, I think you waited on the result. |
|
@AndrienkoAleksandr the issue is that it doesn't test extensions/eclipse-che-theia-plugin-remote/src/node/plugin-remote-backend-module.ts in the current happy path as it's using a predefined image for sidecar (and not the one that is built) |
* Add buildkit-base dev plugin * Change formatting * Change containerPath on mountPath * Allow to use any URI for plugin logo * Set memory limitation to 1G * Remove pattern to validate plugin logo image * Return back pattern to validate plugin logo * Update pattern to check plugin icon Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
What does this PR do?
Use theia-plugin-ext from node_modules. We need this because nexe tool doesn't resolve path with
__dirname.What issues does this PR fix or reference?
Needed for eclipse-che/che#13387
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com