This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Update: Display product logo as image instead displaying in text #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Guliy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Guliy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Guliy <vgulyy@redhat.com>
vitaliy-guliy
requested review from
l0rd,
mmorhun,
olexii4,
rhopp,
sunix and
vparfonov
as code owners
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
benoitf
reviewed
Oct 12, 2019
|
@benoitf in what case? |
benoitf
approved these changes
Oct 14, 2019
|
@vitaliy-guliy also before merging, a PR to documentation needs to be done for updated changes |
|
@benoitf let's merge a document after mergin this PR, as it will use an example for the Code Ready Workspaces, which will use the feature provided by this PR |
|
I need |
|
Draft PR to che-docs eclipse-che/che-docs#843 |
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
* updates from CRW 2.2 Change-Id: I777b9353d9634f810598effa51ea88f26983a171 Signed-off-by: nickboldt <nboldt@redhat.com> * make README and build.sh more generic so it's more closely aligned to devfile reg script and downstream version Change-Id: Ibb2ae67ac5442e85b9aceba4500b25deb457b9aa Signed-off-by: nickboldt <nboldt@redhat.com> * rename build/dockerfiles/content_sets_centos8_appstream.repo to build/dockerfiles/content_sets_centos8.repo and include baseos repo too Change-Id: Ie2cede8bbf5f9d55089a6e2acd24b8733e1b6003 Signed-off-by: nickboldt <nboldt@redhat.com> * rename build/dockerfiles/fedora.repo to build/dockerfiles/content_sets_fedora30.repo for consistency/accuracy Change-Id: I732f8d891bded2400bac635c43dd3b212e7b13cc Signed-off-by: nickboldt <nboldt@redhat.com> * updates from CRW 2.2 Change-Id: Ie8df16a14c44a4ccdaedeb02e045a504de18385a Signed-off-by: nickboldt <nboldt@redhat.com> * fix broken shellcheck source directive;remove duplicate declaration of SCRIPT_DIR Change-Id: I12a670025b18ace6a64f1a2a7201160d751bd594 Signed-off-by: nickboldt <nboldt@redhat.com> * yet more shellcheck fixes Change-Id: I6ce96afa77d9791b74dd1d638cbcbcf0c23aff1e Signed-off-by: nickboldt <nboldt@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows to display product logo as image instead displaying it in text.
To customize Che-Theia product JSON file should have two logo images for dark and light theme. If so, logo images will be shown depending on the current theme.
If product JSON will have only one image, it will be not theme dependent.
What issues does this PR fix or reference?
eclipse-che/che#14845
eclipse-che/che#14110