Rework images for remote plugins #485

evidolob · 2019-10-15T07:16:38Z

What does this PR do?

Rewrites remote plugins images, to avoid extending theia-endpoint-runtime image and using new remote plugin runtime binary injection.

What issues does this PR fix or reference?

eclipse-che/che#14797

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

…rkImages

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

che-bot · 2019-10-15T09:00:21Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

che-bot · 2019-10-18T12:15:19Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

che-bot · 2019-10-22T14:51:30Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-22T15:11:28Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

che-bot · 2019-10-24T14:32:33Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

che-bot · 2019-10-24T14:56:18Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

che-bot · 2019-10-24T20:59:28Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

che-bot · 2019-10-25T01:31:47Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

AndrienkoAleksandr · 2019-10-25T07:33:00Z

@mmorhun @svor @tolusha @azatsarynnyy @benoitf @amisevsk Pr updated.

benoitf · 2019-10-25T07:42:57Z

hi @AndrienkoAleksandr
CMD ${PLUGIN_REMOTE_ENDPOINT_EXECUTABLE} is not added automatically by a broker?

I thought that images were just taking care of running on openshift with an entrypoint and then the command is added by a 3rd party entity ?

benoitf · 2019-10-25T07:46:16Z

dockerfiles/remote-plugin-java8/etc/entrypoint.sh

@@ -0,0 +1,32 @@
+#!/bin/sh


maybe entrypoint.sh could be copied from a template with build.include script so we don't need to push it to git 30 times (better to maintain)

The same for the instructions that are part of Dockerfile to make it compliant

AndrienkoAleksandr · 2019-10-25T08:45:30Z

CMD ${PLUGIN_REMOTE_ENDPOINT_EXECUTABLE} is not added automatically by a broker?

Override Dockerfile#CMD is easy to implement in plugin-broker - one line of the code and fix for few tests.
But we discussed with @amisevsk and decided don't override CMD:
eclipse-che/che-plugin-registry#233 (comment)
eclipse-che/che-plugin-registry#233 (comment)

benoitf · 2019-10-25T09:15:28Z

@AndrienkoAleksandr yeah the step 1, it needs to be enhanced later.

benoitf

copy/paste and uid fixes could be done at a single location instead of duplicating everything
the same for entrypoint/cmd stuff but it's step 1

dmytro-ndp · 2019-10-25T09:23:16Z

crw-ci-test

che-bot · 2019-10-25T09:35:22Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr · 2019-10-25T11:44:57Z

All images manually tested.

che-bot · 2019-10-25T12:00:48Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-theia" docker image: maxura/che-theia:485
"che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:485
"che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:485
"che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:485
Happy path tests DevFile
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

* Extract and use plugin images digest from env. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr and others added 21 commits September 27, 2019 14:35

Add remote binary image.

4ba4ebf

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix up.

4e0e945

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Remove extending from remote-runtime image.

3eb12f0

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Add remote node images: alpine and ubi

319f2d3

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Rework clang.

d26243f

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Rework clang image.

ce6f8d8

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Rework kubernetes and openshift plugins images

763d30f

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Update python, go, php, analytica images.

2c1795b

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Merge branch 'master' of github.com:eclipse/che-theia into reworkImages

f1b5874

Use node for some debuggers.

b330647

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix up.

3165065

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Merge branch 'master' of github.com:eclipse/che-theia into reworkImages

cf00466

Rewrite openshift-connector-0.1.0 docker file

882a404

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Merge branch 'reworkImages' of github.com:eclipse/che-theia into rewo…

fb2997c

…rkImages

Rework remote-plugin-dependency-analytics-0.0.13 image

e379ffd

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Add UBI based images for k8s and openshift plugins

9cc92eb

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

add docker file for java8 based on openjdk-8-rhel8

bed4965

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Add image for java 11 plugin, based on 'openjdk-11-rhel8'

5aa794f

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Add ubi based images for plython plugins

809858e

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Merge branch 'master' of github.com:eclipse/che-theia into reworkImages

abc51e2

Rename 'Dockerfile.rhel(ubi)' to 'rhel.Dockerfile'

30e9882

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

evidolob requested review from svor, azatsarynnyy and tolusha October 15, 2019 07:16

evidolob assigned evidolob and AndrienkoAleksandr Oct 15, 2019

Add php 7.2 ubi Dockerfile

e38d01b

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Add Analytics remote plugin docker image based on ubi8

b2c8539

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Rework kubernetes 1.0.4 image.

7cd05e9

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Add entrypoint scripts for all sidecar images.

70d3d4d

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Rename user from theia to simple user.

4c1a529

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix up.

b4e6aaf

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr added 2 commits October 25, 2019 00:23

Merge branch 'master' of github.com:eclipse/che-theia into reworkImages

27611c1

Fix up.

a398c83

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr requested review from mmorhun and amisevsk October 25, 2019 07:32

mmorhun approved these changes Oct 25, 2019

View reviewed changes

benoitf reviewed Oct 25, 2019

View reviewed changes

benoitf approved these changes Oct 25, 2019

View reviewed changes

Fix losed CMD.

530d838

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr merged commit d65cb10 into master Oct 25, 2019

AndrienkoAleksandr deleted the reworkImages branch October 25, 2019 11:46

evidolob mentioned this pull request Oct 29, 2019

Disable building and publishing of 'eclipse/che-theia-endpoint-runtime' image #521

Merged

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

Extract and use plugin images digest from env. (#485)

d7bcb4c

* Extract and use plugin images digest from env. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework images for remote plugins #485

Rework images for remote plugins #485

evidolob commented Oct 15, 2019

che-bot commented Oct 15, 2019

che-bot commented Oct 18, 2019

che-bot commented Oct 22, 2019

che-bot commented Oct 22, 2019

che-bot commented Oct 24, 2019

che-bot commented Oct 24, 2019

che-bot commented Oct 24, 2019

che-bot commented Oct 25, 2019

AndrienkoAleksandr commented Oct 25, 2019

benoitf commented Oct 25, 2019 •

edited

Loading

benoitf Oct 25, 2019

AndrienkoAleksandr commented Oct 25, 2019

benoitf commented Oct 25, 2019

benoitf left a comment

dmytro-ndp commented Oct 25, 2019

che-bot commented Oct 25, 2019

AndrienkoAleksandr commented Oct 25, 2019

che-bot commented Oct 25, 2019

Rework images for remote plugins #485

Rework images for remote plugins #485

Conversation

evidolob commented Oct 15, 2019

What does this PR do?

What issues does this PR fix or reference?

che-bot commented Oct 15, 2019

che-bot commented Oct 18, 2019

che-bot commented Oct 22, 2019

che-bot commented Oct 22, 2019

che-bot commented Oct 24, 2019

che-bot commented Oct 24, 2019

che-bot commented Oct 24, 2019

che-bot commented Oct 25, 2019

AndrienkoAleksandr commented Oct 25, 2019

benoitf commented Oct 25, 2019 • edited Loading

benoitf Oct 25, 2019

Choose a reason for hiding this comment

AndrienkoAleksandr commented Oct 25, 2019

benoitf commented Oct 25, 2019

benoitf left a comment

Choose a reason for hiding this comment

dmytro-ndp commented Oct 25, 2019

che-bot commented Oct 25, 2019

AndrienkoAleksandr commented Oct 25, 2019

che-bot commented Oct 25, 2019

benoitf commented Oct 25, 2019 •

edited

Loading