Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix compilation for theia changes #743

Closed
wants to merge 1 commit into from

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented May 12, 2020

What does this PR do?

This is a minimal change to make che-theia compile with the changes from eclipse-theia/theia#7620

Note that we only need to merge this if we can't merge #739 in a timely fashion.

What issues does this PR fix or reference?

eclipse-theia/theia#7446

Release Notes

N/A

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:743
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:743

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@tsmaeder
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:743
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:743

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@benoitf
Copy link
Contributor

benoitf commented May 12, 2020

FYI @tsmaeder the node-build is failing

you should bump theia version in yarn.lock

@tsmaeder
Copy link
Contributor Author

@benoitf sorry, can you be more specific? I'm not aware what needs to be done there.

@tsmaeder
Copy link
Contributor Author

Closing in favor of #739

@tsmaeder tsmaeder closed this May 12, 2020
@tsmaeder tsmaeder reopened this May 12, 2020
@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:743
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:743

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@tsmaeder tsmaeder closed this May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants