Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Show recent Che workspaces in Theia editor #800

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Show recent Che workspaces in Theia editor #800

merged 1 commit into from
Jul 15, 2020

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Jul 9, 2020 •
edited
Loading

What does this PR do?

This feature request provides an ability to switch to another Che workspace directly from Theia editor.

Go to File menu and choose Open Recent Workspace...

Снимок экрана 2020-07-13 в 18 50 16

It will open workspace list, sorted by modification time:

Снимок экрана 2020-07-13 в 18 49 30

Then developer will be notified if current workspace should be stopped:

Снимок экрана 2020-07-13 в 18 53 44

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

eclipse-che/che#17034

Release Notes

Show recent Che workspaces in Theia editor.

@che-bot
Copy link
Contributor

che-bot commented Jul 9, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Jul 10, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Jul 10, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@vzhukovs vzhukovs self-assigned this Jul 13, 2020
@vzhukovs vzhukovs added the kind/enhancement New feature or request label Jul 13, 2020
@vzhukovs vzhukovs marked this pull request as ready for review July 13, 2020 15:56
@che-bot
Copy link
Contributor

che-bot commented Jul 13, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

azatsarynnyy
azatsarynnyy reviewed Jul 14, 2020
View reviewed changes
extensions/eclipse-che-theia-workspace/src/browser/che-quick-open-workspace.ts Outdated Show resolved Hide resolved
extensions/eclipse-che-theia-workspace/src/browser/che-quick-open-workspace.ts Show resolved Hide resolved
extensions/eclipse-che-theia-workspace/src/browser/che-quick-open-workspace.ts Outdated Show resolved Hide resolved
extensions/eclipse-che-theia-workspace/src/browser/che-quick-open-workspace.ts Show resolved Hide resolved
extensions/eclipse-che-theia-workspace/src/browser/che-quick-open-workspace.ts Outdated Show resolved Hide resolved
extensions/eclipse-che-theia-workspace/src/browser/che-quick-open-workspace.ts Show resolved Hide resolved
extensions/eclipse-che-theia-workspace/src/browser/che-quick-open-workspace.ts Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Jul 14, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@tsmaeder tsmaeder dismissed their stale review July 14, 2020 11:17

I guess in context of the larger change, I'm ok with this one.

@che-bot
Copy link
Contributor

che-bot commented Jul 15, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy azatsarynnyy mentioned this pull request Jul 15, 2020
Closed
10 tasks
@che-bot
Copy link
Contributor

che-bot commented Jul 15, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Jul 15, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@vzhukovs
Show recent Che workspaces in Theia editor
3e703e1 
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs requested a review from tsmaeder July 15, 2020 13:15
@che-bot
Copy link
Contributor

che-bot commented Jul 15, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:800
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:800

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@tsmaeder tsmaeder dismissed their stale review July 15, 2020 15:38

Comments have been addressed

@vzhukovs vzhukovs merged commit 647d813 into master Jul 15, 2020
@vzhukovs vzhukovs deleted the che#17034 branch July 15, 2020 15:46
@azatsarynnyy azatsarynnyy mentioned this pull request Jul 15, 2020
Closed
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jul 19, 2020
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@sideeffffect
Update Scala syntax for VS Code (#800)
71c62dc 
Signed-off-by: sideeffffect <ondra.pelech@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko

@tsmaeder tsmaeder Awaiting requested review from tsmaeder

Assignees

@vzhukovs vzhukovs

Labels
kind/enhancement New feature or request new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vzhukovs @che-bot @azatsarynnyy @tsmaeder @l0rd