Remove webview serializer #878

vitaliy-guliy · 2020-10-13T12:13:54Z

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What does this PR do?

Disables storing state of Welcome page to prevent opening two Welcome pages.

It's a copy of PR #848, which was merged and then reverted.

Should be merged after merging necessary bugfix to upstream eclipse-theia/theia#8621

What issues does this PR fix or reference?

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

che-bot · 2020-10-13T12:45:35Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:878
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:878

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

ericwill · 2020-10-13T12:50:17Z

Just to clarify @vitaliy-guliy, this PR should be fine because the upstream fix is merged now. It failed last time because the upstream one wasn't merged, correct?

vitaliy-guliy · 2020-10-13T12:59:18Z

Just to clarify @vitaliy-guliy, this PR should be fine because the upstream fix is merged now. It failed last time because the upstream one wasn't merged, correct?

The upstream fix is not merged yet eclipse-theia/theia#8621

I think the reason why it failed before was that we didn't use the latest commit of theia. The theia version that we used had a bug in restoring of opened files and webviews. I just merged that PR before we switched to the head theia commit.

To say the truth, it's not very clear what was wrong with that PR as all checks and tests passed.

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

che-bot · 2020-11-17T13:09:44Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:878
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:878

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

che-bot · 2020-11-17T13:48:20Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:878
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:878

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dmytro-ndp · 2020-11-17T15:06:27Z

[crw-ci-test]

che-bot · 2020-11-17T15:26:05Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:878
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:878

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

vitaliy-guliy · 2020-11-17T15:46:00Z

[crw-ci-test]

azatsarynnyy

I've tested several cases:

w/o opened editors - Welcome page is opened
with an opened editor - Welcome page is not opened
Enable/disable welcome plugin user's preference is respected as well

Everything works as expected 👍
Big thanks for the upstream patch #848!

che-bot · 2020-11-17T16:26:37Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:878
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:878

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-17T16:40:45Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:878
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:878

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dmytro-ndp · 2020-11-17T16:52:33Z

@vitaliy-guliy: Could you, please, take a look at Happy path tests failure #878 (comment) ?
Test failed on waiting of workspace readiness - there was no element with xpath = "//div[@id='theia-left-content-panel']//ul[@Class='p-TabBar-content']//li[@title[contains(.,'Explorer')] and contains(@id, 'shell-tab')])'

Here error message from theia container:

2020-11-17 16:38:15.021 root ERROR [hosted-plugin: 54] TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'CommandRegistryImpl'
    |     property 'commandsConverter' -> object with constructor 'CommandsConverter'
    --- property 'commands' closes the circle
    at JSON.stringify (<anonymous>)
    at Function.MessageFactory.request (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:363:166)
    at RPCProtocolImpl.remoteCall (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:190:46)
    at Proxy.target.<computed> (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:164:38)
    at SourceControlImpl.set (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/scm.js:332:24)
    at /default-theia-plugins/vscode-git/extension/dist/main.js:1:73426
    at /default-theia-plugins/vscode-git/extension/dist/main.js:1:4316
    at /home/theia/node_modules/@theia/core/lib/common/event.js:176:33
    at CallbackList.invoke (/home/theia/node_modules/@theia/core/lib/common/event.js:191:39)
    at Emitter.fire (/home/theia/node_modules/@theia/core/lib/common/event.js:318:29)
TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'CommandRegistryImpl'
    |     property 'commandsConverter' -> object with constructor 'CommandsConverter'
    --- property 'commands' closes the circle
    at JSON.stringify (<anonymous>)
    at Function.MessageFactory.request (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:363:166)
    at RPCProtocolImpl.remoteCall (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:190:46)
    at Proxy.target.<computed> (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:164:38)
    at SourceControlImpl.set (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/scm.js:332:24)
    at /default-theia-plugins/vscode-git/extension/dist/main.js:1:73426
    at /default-theia-plugins/vscode-git/extension/dist/main.js:1:4316
    at /home/theia/node_modules/@theia/core/lib/common/event.js:176:33
    at CallbackList.invoke (/home/theia/node_modules/@theia/core/lib/common/event.js:191:39)
    at Emitter.fire (/home/theia/node_modules/@theia/core/lib/common/event.js:318:29)

vitaliy-guliy · 2020-11-18T13:55:39Z

@vitaliy-guliy: Could you, please, take a look at Happy path tests failure #878 (comment) ?
Test failed on waiting of workspace readiness - there was no element with xpath = "//div[@id='theia-left-content-panel']//ul[@Class='p-TabBar-content']//li[@title[contains(.,'Explorer')] and contains(@id, 'shell-tab')])'

It's still unclear for me what's wrong, but it definitely does not depend on changes in this PR.
This PR only prevents appearing extra Welcome pages when refreshing Che-Theia.

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

che-bot · 2020-11-18T14:46:31Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:878
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:878

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dmytro-ndp

Happy path tests have passed #878 (comment)

Change-Id: Icf244c3255edee69d2ac8093154acf860e92929c Signed-off-by: nickboldt <nboldt@redhat.com>

Remove webview serializer

8d168d1

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

vitaliy-guliy requested review from azatsarynnyy, vzhukovs, ericwill and vinokurig October 13, 2020 12:13

vitaliy-guliy requested review from benoitf, svor and tsmaeder as code owners October 13, 2020 12:13

ericwill mentioned this pull request Oct 22, 2020

Plugins Sprint 192 eclipse-che/che#18179

Closed

29 tasks

ericwill mentioned this pull request Nov 12, 2020

Plugins Sprint 193 eclipse-che/che#18354

Closed

34 tasks

Merge with master

9a662f1

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

Fix formatting

b5fa41e

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

azatsarynnyy approved these changes Nov 17, 2020

View reviewed changes

Merge branch 'master' into serialize-webview

13dab76

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

dmytro-ndp approved these changes Nov 18, 2020

View reviewed changes

vitaliy-guliy merged commit 8157662 into master Nov 18, 2020

vitaliy-guliy deleted the serialize-webview branch November 18, 2020 15:59

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

add MM message (#878)

c5ab990

Change-Id: Icf244c3255edee69d2ac8093154acf860e92929c Signed-off-by: nickboldt <nboldt@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove webview serializer #878

Remove webview serializer #878

vitaliy-guliy commented Oct 13, 2020

che-bot commented Oct 13, 2020

ericwill commented Oct 13, 2020

vitaliy-guliy commented Oct 13, 2020 •

edited

Loading

che-bot commented Nov 17, 2020

che-bot commented Nov 17, 2020

dmytro-ndp commented Nov 17, 2020

che-bot commented Nov 17, 2020

vitaliy-guliy commented Nov 17, 2020

azatsarynnyy left a comment

che-bot commented Nov 17, 2020

che-bot commented Nov 17, 2020

dmytro-ndp commented Nov 17, 2020 •

edited

Loading

vitaliy-guliy commented Nov 18, 2020

che-bot commented Nov 18, 2020

dmytro-ndp left a comment

Remove webview serializer #878

Remove webview serializer #878

Conversation

vitaliy-guliy commented Oct 13, 2020

What does this PR do?

What issues does this PR fix or reference?

Happy Path Channel

che-bot commented Oct 13, 2020

ericwill commented Oct 13, 2020

vitaliy-guliy commented Oct 13, 2020 • edited Loading

che-bot commented Nov 17, 2020

che-bot commented Nov 17, 2020

dmytro-ndp commented Nov 17, 2020

che-bot commented Nov 17, 2020

vitaliy-guliy commented Nov 17, 2020

azatsarynnyy left a comment

Choose a reason for hiding this comment

che-bot commented Nov 17, 2020

che-bot commented Nov 17, 2020

dmytro-ndp commented Nov 17, 2020 • edited Loading

vitaliy-guliy commented Nov 18, 2020

che-bot commented Nov 18, 2020

dmytro-ndp left a comment

Choose a reason for hiding this comment

vitaliy-guliy commented Oct 13, 2020 •

edited

Loading

dmytro-ndp commented Nov 17, 2020 •

edited

Loading