Support more than one authentication session #906

vinokurig · 2020-11-04T12:46:54Z

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Handle multiple GitHub authentication sessions.
Add back the vscode built-in github plugin to be able to publish https repositories.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#18227

How to test this PR?

Setup GitHub Identity provider
Start a workspace with GitHub Pull Requests plugin and a project cloned from GitHub by https url.
You can use this devfile to start a workspace:

apiVersion: 1.0.0
metadata:
  name: wksp-custom-dwdiu
projects:
  - name: che-theia
    source:
      location: 'https://github.com/eclipse/che-theia.git'
      type: git
      branch: master
components:
  - type: chePlugin
    reference: 'https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/ms-vscode/vscode-github-pullrequest/0.20.0/meta.yaml'
  - type: cheEditor
    reference: 'https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-906/simple/che-theia-editor.yaml'

Sign-in to the GitHub Pull Requests plugin.
Checkout to a new branch and commit some changes.
Open a new Pull Request, see https://code.visualstudio.com/docs/editor/github#_creating-pull-requests

The GitHub Pull Requests plugin publishes the branch to origin, so an additional GitHub authentication session is requested.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

che-bot · 2020-11-04T13:21:01Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:906
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:906

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-04T16:17:05Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:906
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:906

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-05T09:02:52Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:906
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:906

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

benoitf · 2020-11-05T15:44:22Z

plugins/github-auth-plugin/src/github-auth-plugin.ts

-                session = {
-                    id: 'github-session',
+                const session = {
+                    id: v4(),


do we need uuid or just a counter ?

azatsarynnyy

Maybe, I'm doing something wrong, but here's how it looks on my side:

vinokurig · 2020-11-06T08:46:23Z

@azatsarynnyy
Looks like you are using an old che-plugin-registry image, so the GitHub PR plugin is not updated there.
Please set the version of the che-plugin-registry image to nightly:

Run kubectl edit checluster eclipse-che -n che
Press a key and add pluginRegistryImage: quay.io/eclipse/che-plugin-registry:nightly
Press Esc key and enter wq to apply changes

vinokurig · 2020-11-06T08:49:45Z

@benoitf

do we need uuid or just a counter ?

uuid looks simpler for me.

benoitf · 2020-11-06T08:51:02Z

@vinokurig I think the devfile you're suggesting, you should use reference: and link to the master version of plug-in registry meta.yaml so devfile, host it on a gist, and provide the link directly so it can be tested with che.openshift.io without any user action

vinokurig · 2020-11-06T09:11:41Z

@benoitf

I think the devfile you're suggesting, you should use reference: and link to the master version of plug-in registry meta.yaml so devfile, host it on a gist, and provide the link directly so it can be tested with che.openshift.io without any user action

Yes you are right, I've edited the description.

vinokurig · 2020-11-06T09:13:27Z

@azatsarynnyy Please use the edited devfile from the description.

azatsarynnyy · 2020-11-06T15:30:51Z

@azatsarynnyy Please use the edited devfile from the description.

Thanks @vinokurig ! Checking...

azatsarynnyy · 2020-11-06T15:46:53Z

@vinokurig should the test Devfile also include Che Theia Editor from this PR?

apiVersion: 1.0.0
metadata:
  name: wksp-custom-dwdiu
projects:
  - name: che-theia
    source:
      location: 'https://github.com/eclipse/che-theia.git'
      type: git
components:
  - type: chePlugin
    reference: 'https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/ms-vscode/vscode-github-pullrequest/0.20.0/meta.yaml'
  - type: cheEditor
    reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-906/simple/che-theia-editor.yaml

che-bot · 2020-11-09T08:32:41Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:906
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:906

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

benoitf · 2020-11-09T09:05:01Z

dockerfiles/theia/Dockerfile

@@ -9,8 +9,9 @@
 #   Red Hat, Inc. - initial API and implementation
 ###
 # Builder Image
-#
-FROM #{INCLUDE:docker/${BUILD_IMAGE_TARGET}/builder-from.dockerfile}
+#yarn


yes, removed the leftovers .

che-bot · 2020-11-09T09:24:40Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:906
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:906

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

che-bot · 2020-11-09T10:01:32Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:906
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:906

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

benoitf · 2020-11-09T10:08:56Z

does it require eclipse-theia/theia#8725 ?

vinokurig · 2020-11-09T11:30:06Z

No, they can be merged separately

vinokurig · 2020-11-09T12:03:52Z

@azatsarynnyy

@vinokurig should the test Devfile also include Che Theia Editor from this PR?

apiVersion: 1.0.0
metadata:
 name: wksp-custom-dwdiu
projects:
 - name: che-theia
   source:
     location: 'https://github.com/eclipse/che-theia.git'
     type: git
components:
 - type: chePlugin
   reference: 'https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/ms-vscode/vscode-github->pullrequest/0.20.0/meta.yaml'
 - type: cheEditor
   reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-906/simple/che-theia-editor.yaml

Thank you for the suggestion, added it to the description.

benoitf

It worked
(using the devfile of description, devfile of the latest comment has an invalid -> string)

But it is asked me again to authenticate with github

I used the same workspace but it is asking me several times to use github authentication while I didn't restart che, etc.

vinokurig · 2020-11-09T14:00:13Z

The built in vscode github plugin is a separate plugin which requires another GitHub authentication session. It doesn't mean that if you signed in the GitHub Pull Requests plugin the built in GitHub plugin signed in. vscode behaves in the same way.

benoitf · 2020-11-09T14:50:59Z

I understand that it's on different plug-ins but still, the user experience is not good.
I'm expecting single sign-on between git plug-in and github PR plug-in

benoitf

forgot to approve this morning

* Update Che-Theia repository localtion * Update Che-Theia repository location Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Support more than one authentication session

00650a8

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig requested review from azatsarynnyy, benoitf, ericwill, RomanNikitenko, svor, tsmaeder, vitaliy-guliy and vzhukovs as code owners November 4, 2020 12:46

vinokurig mentioned this pull request Nov 4, 2020

Introduce Git* extensions to Che-Theia eclipse-che/che#18281

Closed

merge with master

82c7e81

merge with master

9b423a6

benoitf reviewed Nov 5, 2020

View reviewed changes

azatsarynnyy reviewed Nov 5, 2020

View reviewed changes

Merge branch 'master' of github.com:eclipse/che-theia into che-18227

9efbd0e

vinokurig force-pushed the che-18227 branch 2 times, most recently from d1a5c9e to 23d8811 Compare November 9, 2020 08:59

benoitf reviewed Nov 9, 2020

View reviewed changes

Fix uuid version

f0920e3

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig force-pushed the che-18227 branch from 23d8811 to f0920e3 Compare November 9, 2020 09:25

benoitf reviewed Nov 9, 2020

View reviewed changes

benoitf approved these changes Nov 9, 2020

View reviewed changes

vinokurig merged commit ca076c6 into master Nov 9, 2020

vinokurig deleted the che-18227 branch November 9, 2020 15:25

vinokurig mentioned this pull request Nov 11, 2020

Publish to GitHub command doesn't make sense eclipse-che/che#18341

Closed

22 tasks

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

Update Che-Theia repository location (#906)

8af14d2

* Update Che-Theia repository localtion * Update Che-Theia repository location Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support more than one authentication session #906

Support more than one authentication session #906

vinokurig commented Nov 4, 2020 •

edited

Loading

che-bot commented Nov 4, 2020

che-bot commented Nov 4, 2020

che-bot commented Nov 5, 2020

benoitf Nov 5, 2020

azatsarynnyy left a comment

vinokurig commented Nov 6, 2020

vinokurig commented Nov 6, 2020

benoitf commented Nov 6, 2020

vinokurig commented Nov 6, 2020

vinokurig commented Nov 6, 2020

azatsarynnyy commented Nov 6, 2020

azatsarynnyy commented Nov 6, 2020

che-bot commented Nov 9, 2020

benoitf Nov 9, 2020

vinokurig Nov 9, 2020

che-bot commented Nov 9, 2020

che-bot commented Nov 9, 2020

benoitf commented Nov 9, 2020

vinokurig commented Nov 9, 2020

vinokurig commented Nov 9, 2020

benoitf left a comment

vinokurig commented Nov 9, 2020

benoitf commented Nov 9, 2020

benoitf left a comment

Support more than one authentication session #906

Support more than one authentication session #906

Conversation

vinokurig commented Nov 4, 2020 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

che-bot commented Nov 4, 2020

che-bot commented Nov 4, 2020

che-bot commented Nov 5, 2020

benoitf Nov 5, 2020

Choose a reason for hiding this comment

azatsarynnyy left a comment

Choose a reason for hiding this comment

vinokurig commented Nov 6, 2020

vinokurig commented Nov 6, 2020

benoitf commented Nov 6, 2020

vinokurig commented Nov 6, 2020

vinokurig commented Nov 6, 2020

azatsarynnyy commented Nov 6, 2020

azatsarynnyy commented Nov 6, 2020

che-bot commented Nov 9, 2020

benoitf Nov 9, 2020

Choose a reason for hiding this comment

vinokurig Nov 9, 2020

Choose a reason for hiding this comment

che-bot commented Nov 9, 2020

che-bot commented Nov 9, 2020

benoitf commented Nov 9, 2020

vinokurig commented Nov 9, 2020

vinokurig commented Nov 9, 2020

benoitf left a comment

Choose a reason for hiding this comment

vinokurig commented Nov 9, 2020

benoitf commented Nov 9, 2020

benoitf left a comment

Choose a reason for hiding this comment

vinokurig commented Nov 4, 2020 •

edited

Loading