This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Adapt Telemetry Plug-in API to a single-host mode #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
21 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
22 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
azatsarynnyy
force-pushed
the
telemetry-fix
branch
from
December 10, 2020 19:35
99a2cc0
to
3ed05c9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[crw-ci-test --rebuild] |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
azatsarynnyy
changed the title
[WIP] Adapt Telemetry Plug-in API to a single-host mode
Adapt Telemetry Plug-in API to a single-host mode
Dec 11, 2020
azatsarynnyy
requested review from
ericwill,
RomanNikitenko,
svor,
tsmaeder,
vinokurig,
vitaliy-guliy and
vzhukovs
as code owners
December 11, 2020 11:02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RomanNikitenko
approved these changes
Dec 14, 2020
@RomanNikitenko thank you for testing it! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
/client-ip
service URL for a single-host mode.hosted-instance-log
. As such messages are recognized asvscode.TextDocumentChangeEvent
s.See the details in Logging to the console from a plug-in may cause the cyclic messaging che#18598
Screenshot/screencast of this PR
What issues does this PR fix or reference?
closes eclipse-che/che#18503
closes eclipse-che/che#18489
How to test this PR?
To test that the PR fixes eclipse-che/che#18503:
chectl server:deploy --platform=minikube --installer=operator --che-operator-cr-patch-yaml=patch.yaml
where
patch.yaml
content isOpen Chrome/FireFox DevTools and make any edit in a file.
Make sure that there's a request to
/client-ip
service and it returns the data.Make sure the correct telemetry events are sent to Che-Theia backend, e.g.:
To test that the PR fixes eclipse-che/che#18489:
/client-ip
service.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable