Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open in Terminal feature does not work if workdir is not set to the projects root #10894

Closed
gazarenkov opened this issue Aug 23, 2018 · 1 comment
Closed

Open in Terminal feature does not work if workdir is not set to the projects root #10894

gazarenkov opened this issue Aug 23, 2018 · 1 comment
Assignees
@vparfonov @vzhukovs
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone
6.15.0

Comments

@gazarenkov
Copy link
Contributor

gazarenkov commented Aug 23, 2018 •
edited
Loading

It seems Project Tree's -> Open in Terminal relies on the fact that workdir always on projects root so it performs:

cd relative project path

if it is not the case having:

bash: cd: project-path: No such file or directory
@gazarenkov gazarenkov added kind/bug Outline of a bug - must adhere to the bug report template. team/ide labels Aug 23, 2018
@vparfonov vparfonov mentioned this issue Aug 23, 2018
Closed
24 tasks
@gazarenkov gazarenkov added the severity/P1 Has a major impact to usage or development of the system. label Sep 14, 2018
@gazarenkov
Copy link
Contributor Author

P1, seems like really quick fix

@vparfonov vparfonov mentioned this issue Nov 7, 2018
Closed
29 tasks
@vzhukovs vzhukovs assigned vzhukovs and vparfonov and unassigned vparfonov Nov 12, 2018
@vzhukovs vzhukovs mentioned this issue Nov 12, 2018
Merged
@vzhukovs vzhukovs added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 14, 2018
@vparfonov vparfonov mentioned this issue Nov 28, 2018
Closed
15 tasks
vzhukovs added a commit that referenced this issue Nov 30, 2018
@vzhukovs
Use absolute folder path to open it as working dir in terminal (#11914)
b3da3eb 
### What does this PR do?
This changes proposal modifies the behavior of _Open in Terminal_ action, so the current directory path pass to terminal options in absolute path form instead of relative as it was before.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

### What issues does this PR fix or reference?
#10894 
<!-- #### Changelog -->
<!-- The changelog will be pulled from the PR's title. 
     Please provide a clear and meaningful title to the PR and don't include issue number -->


#### Release Notes
<!-- markdown to be included in marketing announcement - N/A for bugs -->
N/A

#### Docs PR
<!-- Please add a matching PR to [the docs repo](https://github.com/eclipse/che-docs) and link that PR to this issue.
Both will be merged at the same time. -->
N/A
@vzhukovs vzhukovs added this to the 6.15.0 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vparfonov vparfonov

@vzhukovs vzhukovs

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
6.15.0
Development

No branches or pull requests
3 participants
@gazarenkov @vparfonov @vzhukovs