Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing API for Language Support Che 7 Plug-Ins #13007

Closed
tsmaeder opened this issue Mar 28, 2019 · 9 comments
Closed

Missing API for Language Support Che 7 Plug-Ins #13007

tsmaeder opened this issue Mar 28, 2019 · 9 comments
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@tsmaeder
Copy link
Contributor

This lists missing VS Code API referenced from Language Support Plugins used in Che 7 GA.

@tsmaeder tsmaeder added the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Mar 28, 2019
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Mar 28, 2019

Where there is a version number, the API was introduced after the version of the API we initially targeted (1.29.1)

Commands

  • workbench.action.debug.restart (vscode-java-debug)
  • workbench.action.debug.start (vcode-node-debug)
  • workbench.action.openGlobalSettings (vscode-go)
  • workbench.action.openWorkspaceSettings (vscode-go)
  • workbench.action.reloadWindow (vscode-go, vscode-java, vscode-xml, vscode-python)
  • workbench.action.reportIssues (vscode-typescript)
  • workbench.action.openSettingsJson (vscode-java)
  • workbench.action.gotoSymbol (vscode-go)
  • workbench.action.showAllSymbols (vscode-go)
  • editor.action.rename (vscode-python, vscode-typescript) Implement editor.action.rename comand eclipse-theia/theia#5215
  • editor.action.formatSelection (vscode-java) Implement editor.action.formatXXX commands eclipse-theia/theia#5216
  • editor.action.formatDocument (vscode-python) Implement editor.action.formatXXX commands eclipse-theia/theia#5216
  • editor.action.gotoDeclaration (vscode-go)
  • editor.action.goToImplementation (vscode-go)
  • editor.action.triggerParameterHints (vscode-typescript)
  • editor.autoclosingBrackets
  • revealLine (vscode-python)
  • revealFileInOS (vscode-typescript)
  • search.exclude (vscode-python)

API

  • vscode.InputBox (vscode-python)
  • vscode.env
    • openExternal (vscode-python) (1.31.1)
    • appName (vscode-python)
    • appRoot (vscode-python)
    • language (vscode-python, vscode-typescript)
    • machineId (vscode-python)
    • sessionId (vscode-python)
  • vscode.Event.bind (vscode-python)
  • vscode.extensions.onDidChange (vscode-java, vscode-yaml, vscode-typescript)
  • vscode.CodeAction.isPreferred (1.32.3) (vscode-typescript)
  • vscode.CodeActionKind
    • intersects (vscode-typescript) (1.31.1)
    • SourceFixAll (vscode.typescript)
  • vscode.DiagnosticTag (vscode-typescript) (our API checker reports this as implemented)
  • vscode.LocationLink (vscode-typescript) (1.30.2)
  • vscode.QuickInput (vscode-python)
  • vscode.QuickInputButton (vscode-python)
  • vscode.QuickInputButtons (vscode-python)
  • vscode.QuickPick (vscode-python, vscode-java)
  • vscode.TextEditor.show (vscode-python)
  • vscode.Selection
    • start (vscode-java-debug, vscode-go, vscode-python)
    • end (vscode-go, vscode-python)
    • isEmpty (vscode-go, vscode-python)
  • vscode.SignatureHelpContext (vscode-typescript) (1.30.2)
  • vscode.SignatureHelpTriggerKind (vscode-typescript) (1.30.2)
    • ContentChange (vscode-typescript)
    • Invoke (vscode-typescript)
    • TriggerCharacter (vscode-typescript)
  • vscode.TextEditor.show (vscode-python)
  • vscode.ThemeIcon.Folder
  • vscode.window.createInputBox (vscode-python)
  • vscode.window.createQuickPick (vscode-python, vscode-java)

@tsmaeder
Copy link
Contributor Author

Collected from #12996. I haven't looked at the "dynamicCommandCalls" yet. These might reveal more used commands.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Mar 28, 2019

List now includes dynamic command invocations. Note that we can't really track commands that might be originating in language servers (CodeActions, for example), but they should not rely on the host being VS Code, so if they are clean, we are ok.

@benoitf
Copy link
Contributor

benoitf commented Mar 29, 2019

vscode.java/0.42.0 is also using vscode.extensions.onDidChange() which is not available.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Apr 1, 2019

Thanks for detecting that. The bigger question, though: which is that not being picked up by the tool? If it's not reliable, it's a lot less useful.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Apr 1, 2019

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Apr 2, 2019

I'll need to do another pass over the repos, unfortunately. The positives still are real positives that should be fixed.

@tsmaeder tsmaeder mentioned this issue Apr 5, 2019
15 tasks
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Apr 5, 2019

Reran the checks with the newest version of the tool and master of the extensions

@che-bot
Copy link
Contributor

che-bot commented Dec 5, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants