Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

extensions.onDidChange not being reported as used for vscode-java #1

Closed
tsmaeder opened this issue Apr 1, 2019 · 2 comments
Closed

Comments

@tsmaeder
Copy link

tsmaeder commented Apr 1, 2019

When I run the tool agains vscode-java (https://github.com/redhat-developer/vscode-java/), the API call "extensions.onDidChange" is not being picked up.
My suspicion is that it is not being picked up because vscode-java imports the extensions namespace like so:

import { ..., extensions ,...} from 'vscode-java';

Since this seems like perfectly valid code, we might be missing lots of API usages right now.

@akosyakov
Copy link
Member

@tsmaeder it should be fixed by b22c487 Could you try?

It respects property access syntax now.

@tsmaeder
Copy link
Author

tsmaeder commented Apr 1, 2019

looks much better.

 "missingSymbols": [
    "\"vscode\".Extension.extensionPath",
    "\"vscode\".QuickInput.show",
    "\"vscode\".QuickPick",
    "\"vscode\".QuickPick.items",
    "\"vscode\".QuickPick.onDidChangeSelection",
    "\"vscode\".QuickPick.onDidHide",
    "\"vscode\".QuickPick.placeholder",
    "\"vscode\".QuickPick.show",
    "\"vscode\".QuickPick.step",
    "\"vscode\".QuickPick.title",
    "\"vscode\".QuickPick.totalSteps",
    "\"vscode\".extensions.onDidChange",
    "\"vscode\".window.createQuickPick"
  ],

@tsmaeder tsmaeder closed this as completed Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants