Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes Plugin] Kubernetes: Diff command doesn't open diff view when running in a sidecar #13044

Closed
azatsarynnyy opened this issue Apr 2, 2019 · 2 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@azatsarynnyy
Copy link
Member

Description

Kubernetes: Diff command of the K8s Tooling plugin shows the difference between a local copy of the object, and that which is deployed to the cluster.

When the plugin running in a sidecar, the command doesn't open a diff viewer.

@vzhukovs
Copy link
Contributor

Investigation shows, that there is an offbeat use case.

Kubernetes plugin invokes native command

$kubectl get -o yaml objet/name

and saves output into temporary file. Since plugin runs in side car, it has belongs to dedicate file system. Then it calls VSCode plugin api to show diff, as an argument it pass' file path only, then API call goes through the RPC protocol to Theia container and then IDE tries to open diff viewer. First file, that has been opened in editor exists on file system, but the second one, come as an argument from plugin doesn't, because it exists on different file system.

Based on this, possible solution is to share /tmp volume across all sidecars and Theia container, but on the other hand this has to be tested to find out whether we can get file collisions.

@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Sep 3, 2019

See #13614. That may help with reading a file in another sidecar.
Here's the demo https://www.youtube.com/watch?v=vrNcqfFJ2nw&feature=youtu.be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants