Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Theia Plugin APIs to support VS Code Kubernetes Tooling #10574

Closed
25 of 27 tasks
l0rd opened this issue Jul 30, 2018 · 13 comments
Closed
25 of 27 tasks

Add Theia Plugin APIs to support VS Code Kubernetes Tooling #10574

l0rd opened this issue Jul 30, 2018 · 13 comments
Assignees
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.

Comments

@l0rd
Copy link
Contributor

l0rd commented Jul 30, 2018

The goal is to be able to run VSCode Kubernetes Tooling as a Theia plugin. To achieve it we should extend Theia Plugin API.

This is the list of initial k8s tooling commands we want to support:

  • apply
  • get
  • describe
  • follow
  • logs
  • follow events

TODO: List the needed API
Workspace API's:

Languages API's: eclipse-theia/theia#2341

Window :

Debug:

  • debug.registerDebugConfigurationProvider
  • debug.activeDebugSession
  • onDidTerminateDebugSession
  • onDidChangeActiveDebugSession
  • startDebugging

Menu API :

Contribution Points used in package.json :

Related PR's:

@l0rd l0rd added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. team/ide labels Jul 30, 2018
@l0rd
Copy link
Contributor Author

l0rd commented Jul 30, 2018

@l0rd
Copy link
Contributor Author

l0rd commented Oct 17, 2018

@vparfonov @slemeur I added the list of commands to support first:

  • apply
  • get
  • describe
  • follow
  • logs
  • follow events

@apupier
Copy link
Contributor

apupier commented Oct 23, 2018

It would be nice to cover the use case of Camel Language Server https://marketplace.visualstudio.com/items?itemName=camel-tooling.vscode-apache-camel
The VS Code plugin is here https://github.com/camel-tooling/camel-lsp-client-vscode
The Server code is here https://github.com/camel-tooling/camel-language-server

I'm not sure how to know all the API/commands that are used.

On Language Server side, we can see the "activated" features here https://github.com/camel-tooling/camel-language-server/blob/c50fb5954cf521b3471651e2856ca4e1ce00b8a9/src/main/java/com/github/cameltooling/lsp/internal/CamelLanguageServer.java#L78-L86

Please note that for now when using the released VS Code plugin NPEs are thrown, which seems to be due to the fact that exitServer is called before a startServer. I made it more robust to avoid NPE camel-tooling/camel-language-server#166 and it will be better in next release.
Even wit this new version, it is not working, there is no more errors or logs.
Reported camel-tooling/camel-lsp-client-vscode#72 to be able to remote debug the server part.

@slemeur
Copy link
Contributor

slemeur commented Oct 23, 2018

Hi @apupier.
Are you asking to prioritize the different plugin APIs that you might need for the Camel Language Server?
Or do you have a particular use case related to a Camel with Kubernetes that you'd like to see covered?

@apupier
Copy link
Contributor

apupier commented Oct 23, 2018

Are you asking to prioritize the different plugin APIs that you might need for the Camel Language Server?

Yes, i'm asking if it possible to cover the different plugin APIs that Camel Language Server is using.

Or do you have a particular use case related to a Camel with Kubernetes that you'd like to see covered?

The Camel Language server is independent from Kubernetes. I have some Kubernetes related stuff but it is not related to this request.

@slemeur
Copy link
Contributor

slemeur commented Oct 23, 2018

ok :)
That's why I asked. This issue is related to the work needed to support the VSCode Kubernetes plugin in Che.
Do you mind creating a separate issue for your requirement?

@apupier
Copy link
Contributor

apupier commented Oct 23, 2018

That's why I asked. This issue is related to the work needed to support the VSCode Kubernetes plugin in Che.

oups sorry, I thought it was a top level issue for all VS code plugins. my bad.

Do you mind creating a separate issue for your requirement?

here it is #11705

@l0rd
Copy link
Contributor Author

l0rd commented Nov 7, 2018

For apply command we need eclipse-theia/theia#2979 to be merged upstream

@azatsarynnyy
Copy link
Member

For context menus we need eclipse-theia/theia#3646

@azatsarynnyy
Copy link
Member

I've updated the description with a couple of tasks related to Menu API

@slemeur slemeur mentioned this issue Dec 11, 2018
69 tasks
@l0rd l0rd mentioned this issue Feb 19, 2019
@vparfonov
Copy link
Contributor

vparfonov commented Feb 22, 2019

Need to fix:

@PavelSosin
Copy link

Hint: if you had minikube installed on you computer ( desktop/laptop) and now is trying to switch to Docker desktop Kubernetes cluste) you can experience context switch glitch - minikube is the only choice. It is easily repairable: rename you minikube config.json to something like configOld.json and set KUBECONFIG system variable pointing to kubeconfig file create by Docker Desktop installation.

@vparfonov
Copy link
Contributor

vparfonov commented May 15, 2019

Going to close this epic, will continue working on some separate issues like:
[k8s plugin] Kubernetes:Run command should work w/o Docker che #13316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

6 participants