Fix loading a plugin that contributes a language with configuration options provided in a JSON file with comments #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on options provided in a JSON file with comments Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
azatsarynnyy
force-pushed
the
az/parser
branch
from
1f45b24
to
0a12613
Compare
benoitf
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces using JSON parser by JSONC parser for reading the configuration options of the contributed language.
In my case I want to load VSCode Kubernetes plugin which contributes
helmlanguage with configuration options provided in a file in JSONC format.Theia cannot load the plugin due to the following parsing error:
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/vscode-unpacked/vscode-kubernetes-tools-0.1.14.vsix root INFO accepting packagejson with engines { vscode: '^1.23.0' } root ERROR Uncaught Exception: SyntaxError: Unexpected token / in JSON at position 28 root ERROR SyntaxError: Unexpected token / in JSON at position 28 at JSON.parse (<anonymous>) at VsCodePluginScanner.TheiaPluginScanner.readLanguage (/home/artem/projects/github/theia-ide/theia/packages/plugin-ext/lib/hosted/node/scanners/scanner-theia.js:181:45) at /home/artem/projects/github/theia-ide/theia/packages/plugin-ext/lib/hosted/node/scanners/scanner-theia.js:165:68 at Array.map (<anonymous>) at VsCodePluginScanner.TheiaPluginScanner.readLanguages (/home/artem/projects/github/theia-ide/theia/packages/plugin-ext/lib/hosted/node/scanners/scanner-theia.js:165:29) at VsCodePluginScanner.TheiaPluginScanner.readContributions (/home/artem/projects/github/theia-ide/theia/packages/plugin-ext/lib/hosted/node/scanners/scanner-theia.js:84:34) at VsCodePluginScanner.getModel (/home/artem/projects/github/theia-ide/theia/packages/plugin-ext-vscode/lib/node/scanner-vscode.js:66:35) at MetadataScanner.getPluginMetadata (/home/artem/projects/github/theia-ide/theia/packages/plugin-ext/lib/hosted/node/metadata-scanner.js:45:28) at HostedPluginReader.getPluginMetadata (/home/artem/projects/github/theia-ide/theia/packages/plugin-ext/lib/hosted/node/plugin-reader.js:61:43) at /home/artem/projects/github/theia-ide/theia/packages/plugin-ext/lib/hosted/node/plugin-service.js:117:47 root INFO [hosted-plugin: 25971] PLUGIN_HOST(25971) starting instanceIt's needed for eclipse-che/che#10574