-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give more flexibility on where devfile registry can served up #13634
Comments
I'm trying to get that to work by submitting a PR against che to pretty much suggest what you have said |
Based on the PR discussion #13645 (comment) I would +1 to set milestone 7.0.0 and merge the PR |
+1, added to che7GA and milestone 7.0.0. |
Thank you! |
@makandre : As the PR been merged, is this issue solved? |
Hi @slemeur, for my usage I'm packaging a custom assembly where I change the So I have been using |
Thanks for your answer @makandre ! |
I just built again with |
Will there be |
I believe we are currently on However, if all you are doing to modify the assembly is setting
in the container. Generally properties can be overriden at runtime via env vars using the translation |
we have tested the master branch and can see it in there ok |
@amisevsk Thanks for the clarification. I'm able to verify it works now. |
@makandre No problem, happy to help! There's a little more information in an (old, but still valid) doc: https://www.eclipse.org/che/docs/che-6/properties.html#properties-and-environment-variables |
Excellent! Thanks @amisevsk for following-up ! |
Description
I would like to make devfiles I have on GitHub show up in Che dashboard when creating a workspace.
I learned that I can configure Che's devfile registry by changing the
che.workspace.devfile_registry_url
property.It would be great if I can change it so the devfiles can be served up directly from GitHub (e.g. set
che.workspace.devfile_registry_url=https://raw.githubusercontent.com/kabanero-io/codewind-templates/master/
)But this doesn't work; Che takes the url and does a GET on
<url>/devfiles/
to get the contents of theindex.json
(and obviously that won't work for GitHub). If it simply does a GET on<url>/devfiles/index.json
instead, then I believe it would work. (it would be a small change here https://github.com/eclipse/che/blob/master/dashboard/src/components/api/devfile-registry.factory.ts#L46)Reproduction Steps
OS and version:
Diagnostics:
The text was updated successfully, but these errors were encountered: