Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Fix #9 #10

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Fix #9 #10

merged 2 commits into from
Jul 18, 2019

Conversation

makandre
Copy link
Contributor

@makandre makandre commented Jul 17, 2019

I have tested this fix:

  • Regenerated index.json with updated devfiles and index.sh, the output is same as before
    • (script was already getting language from meta.yaml rather than the devfile)
  • Codewind behaves the same as before when pointed to my branch of index.json
  • Che can create workspace from the devfiles now (using f?url= method)
  • Tested with fix for Give more flexibility on where devfile registry can served up eclipse-che/che#13634, can see codewind templates show up, and more importantly, the Projects section is correctly populated with the project name and repository location

image

Signed-off-by: Andrew Mak <makandre@ca.ibm.com>
Signed-off-by: Andrew Mak <makandre@ca.ibm.com>
@makandre makandre requested a review from tobespc July 17, 2019 18:38
Copy link
Collaborator

@tobespc tobespc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobespc tobespc merged commit 8f87a1f into master Jul 18, 2019
@tobespc tobespc deleted the makandre branch July 18, 2019 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants