Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running task #13737

Closed
svor opened this issue Apr 26, 2019 · 8 comments
Closed

Stop running task #13737

svor opened this issue Apr 26, 2019 · 8 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone

Comments

@svor
Copy link
Contributor

svor commented Apr 26, 2019

Description

We should have a functionality to stop/cancel running tasks.
For example if some task executes a process sleep infinity there are should be a way to cancel this process without using a terminal.

@RomanNikitenko
Copy link
Member

Related issue eclipse-theia/theia#5159

@RomanNikitenko
Copy link
Member

We run che tasks using machine exec, machine exec doesn't have ability to stop process.
So, first of all we need to provide ability to stop process on machine exec side and next - provide UI for stopping task.

@slemeur
Copy link
Contributor

slemeur commented May 20, 2019 via email

@RomanNikitenko
Copy link
Member

Changes for https://github.com/eclipse/che-machine-exec are required, so - unfortunately - no.
We discussed about that with @AndrienkoAleksandr and the main problem is to get id of a running process, as far as I understand.

@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide labels Jul 5, 2019
@sunix
Copy link
Contributor

sunix commented Jul 11, 2019

By the way, now we can Ctrl-c to stop a running task as tasks are interactive.
But would be nicer to Ctrl-c when you close the tab right ?

@vparfonov
Copy link
Contributor

depends on #13722

@RomanNikitenko
Copy link
Member

depends on #14659

@RomanNikitenko
Copy link
Member

I implemented stopping che tasks by sending ctrl+c to corresponding terminal widget, but unfortunately, I faced with the issue #14887

@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

6 participants