Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No notification showed when task is finished #14724

Closed
6 of 23 tasks
Katka92 opened this issue Oct 1, 2019 · 7 comments · Fixed by eclipse-che/che-theia#468
Closed
6 of 23 tasks

No notification showed when task is finished #14724

Katka92 opened this issue Oct 1, 2019 · 7 comments · Fixed by eclipse-che/che-theia#468
Assignees
@RomanNikitenko
Labels
status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@Katka92
Copy link
Contributor

Katka92 commented Oct 1, 2019 •
edited
Loading

Describe the bug

When the task is run, user is notified by pop-up like this:
Screenshot from 2019-10-01 12-39-16

In previous version (7.1.0) user were notified in a same way when task ended with message similar too Task che: maven build has exited with code 0.. In current version 7.2.0 no pop-up is shown.

Che version

  • latest
  • nightly
  • other: 7.2.0

Steps to reproduce

  1. Create default Java Maven workspace with example project
  2. Once workspace is ready, click Terminal -> Run task... -> che: mavne build -> Continue without scanning task output
  3. Wait until build finishes
  4. No pop-up is shown.

Expected behavior

The pop-up informing user that task has finished should be shown.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 1, 2019
@tolusha
Copy link
Contributor

tolusha commented Oct 1, 2019

It seems the task is counted as running.

Screenshot from 2019-10-01 14-17-34

@Katka92 Katka92 mentioned this issue Oct 1, 2019
Merged
@l0rd
Copy link
Contributor

l0rd commented Oct 1, 2019

@vparfonov @RomanNikitenko is this normal behavior for latest version of Theia?

@l0rd l0rd added status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 1, 2019
@RomanNikitenko
Copy link
Member

I'm going to investigate the cause of the issue.

@vparfonov can we take it in current sprint as unplanned issue?

@vparfonov
Copy link
Contributor

i don't think it's so critical, we can wait on next sprint

@l0rd
Copy link
Contributor

l0rd commented Oct 2, 2019

Yes I agree with @vparfonov. Not critical, can be postponed until next sprint.

@amisevsk
Copy link
Contributor

amisevsk commented Oct 2, 2019

How did an issue like this pass e2e/happy-path tests? I agree that it's not critical, but also would make any command that naturally doesn't have output on success untrackable to the user.

@RomanNikitenko
Copy link
Member

My current issue is Stop running task #13737,
so I would like to investigate and fix this bug to have ability to test my changes for #13737.

@l0rd @vparfonov
can we take it in current sprint as unplanned issue?

Katka92 added a commit to Katka92/rh-che that referenced this issue Oct 4, 2019
@Katka92
Removing refreshing of browser after failed LS initialization. Add wo…
e0be19b 
…rkarounds for eclipse-che/che#14724.
Katka92 added a commit to Katka92/rh-che that referenced this issue Oct 4, 2019
@Katka92
Removing refreshing of browser after failed LS initialization. Add wo…
9bb78f6 
…rkarounds for eclipse-che/che#14724.
This was referenced Oct 4, 2019
Merged
Closed
@RomanNikitenko RomanNikitenko self-assigned this Oct 4, 2019
@RomanNikitenko RomanNikitenko mentioned this issue Oct 4, 2019
Merged
@vparfonov vparfonov mentioned this issue Oct 4, 2019
Closed
25 tasks
Katka92 added a commit to Katka92/rh-che that referenced this issue Oct 7, 2019
@Katka92
Removing refreshing of browser after failed LS initialization. Add wo…
f5336ed 
…rkarounds for eclipse-che/che#14724.
Katka92 added a commit to Katka92/rh-che that referenced this issue Oct 7, 2019
@Katka92
Removing refreshing of browser after failed LS initialization. Add wo…
7c13135 
…rkarounds for eclipse-che/che#14724.
Katka92 added a commit to redhat-developer/rh-che that referenced this issue Oct 7, 2019
@Katka92
Removing refreshing of browser after failed LS initialization. Add wo…
d722898 
…rkarounds for eclipse-che/che#14724. (#1638)
ibuziuk pushed a commit to redhat-developer/rh-che that referenced this issue Oct 22, 2019
@Katka92 @ibuziuk
Removing refreshing of browser after failed LS initialization. Add wo…
d3ed076 
…rkarounds for eclipse-che/che#14724. (#1638)
ibuziuk pushed a commit to redhat-developer/rh-che that referenced this issue Oct 22, 2019
@Katka92 @ibuziuk
Removing refreshing of browser after failed LS initialization. Add wo…
99a17be 
…rkarounds for eclipse-che/che#14724. (#1638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade vscode-ws-jsonrpc version eclipse-che/che-theia
7 participants
@l0rd @vparfonov @tolusha @RomanNikitenko @amisevsk @Katka92 @che-bot