Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Updating rh-che to the latest '7.3.0' version #1626

Merged
merged 10 commits into from
Oct 22, 2019
Merged

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Sep 23, 2019

What does this PR do?

Updating rh-che to the latest '7.3.0' version

What issues does this PR fix or reference?

eclipse-che/che#14656

How have you tested this PR?

PR check CI

@ibuziuk ibuziuk changed the title Updating rh-che to the latest '7.2.0' version [WIP] Updating rh-che to the latest '7.2.0' version Sep 23, 2019
@centos-ci
Copy link
Collaborator

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 26, 2019

[test]

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 26, 2019

@amisevsk for UD I got No upstream changes detected. but would appreciate double-checking from you

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 26, 2019

[test]

@centos-ci
Copy link
Collaborator

@Katka92
Copy link
Collaborator

Katka92 commented Sep 26, 2019

Test failed on LS and Build&Run commands. I'll investigate further.

@amisevsk amisevsk changed the title [WIP] Updating rh-che to the latest '7.2.0' version Updating rh-che to the latest '7.2.0' version Sep 30, 2019
@centos-ci
Copy link
Collaborator

@centos-ci
Copy link
Collaborator

@Katka92
Copy link
Collaborator

Katka92 commented Oct 1, 2019

Tests are currently failing on creation of workspace: Plugins installation process failed. Error: Plugin broking process for workspace workspacexxaeqtgbuy09cicy failed with error: Failed to download plugin meta: failed to fetch plugin meta.yaml from URL 'https://che-plugin-registry.prod-preview.openshift.io/v3/plugins/eclipse/che-machine-exec-plugin/7.2.0/meta.yaml': Downloading https://che-plugin-registry.prod-preview.openshift.io/v3/plugins/eclipse/che-machine-exec-plugin/7.2.0/meta.yaml failed. Status code 404.

@Katka92
Copy link
Collaborator

Katka92 commented Oct 1, 2019

[test]

@centos-ci
Copy link
Collaborator

@Katka92
Copy link
Collaborator

Katka92 commented Oct 1, 2019

I've investigated test failures and it seems like LS is not started so all LS related tests fails. Build & Run tests fails because previously there was pop-up informing about the finishing of running task. Now no pop-up is shown. It is considered to be a bug, so I created issue for that: eclipse-che/che#14724

@amisevsk
Copy link
Collaborator

amisevsk commented Oct 2, 2019

Retested just now, and it appears the LS problem is mysteriously gone, but eclipse-che/che#14724 is still present. Nevermind, was looking at wrong deployment.

@amisevsk
Copy link
Collaborator

amisevsk commented Oct 2, 2019

[test]

@amisevsk
Copy link
Collaborator

amisevsk commented Oct 2, 2019

Figured out the language server issue: eclipse-che/che#14749

This appears to be a blocker for 7.2 rollout.

@centos-ci
Copy link
Collaborator

@centos-ci
Copy link
Collaborator

@Katka92
Copy link
Collaborator

Katka92 commented Oct 7, 2019

Verified - tests are fixed. LS related tests are failing as expected.

@amisevsk amisevsk changed the title Updating rh-che to the latest '7.2.0' version [WIP] Updating rh-che to the latest '7.3.0' version Oct 8, 2019
@centos-ci
Copy link
Collaborator

@amisevsk
Copy link
Collaborator

I can reproduce various issues in Che. I think the workspace specific ones are related to using 7.1.0 for plugin runner and next for theia/machine-exec.

However I also get

Screenshot from 2019-10-16 10-38-41

when trying to view workspace details.

@centos-ci
Copy link
Collaborator

@amisevsk
Copy link
Collaborator

Starting a workspace fails due to 7.3.0 plugins not being included in plugin registry (che-theia + che-machine-exec). @ibuziuk WDYT about updating prod-preview registry to 7.3.0? This would likely break the preview deployment.

@ibuziuk ibuziuk changed the title [WIP] Updating rh-che to the latest '7.3.0' version Updating rh-che to the latest '7.3.0' version Oct 21, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 21, 2019

[test]

@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 21, 2019

plugin & devifle registries have been updated to the latest (7.3.0) version on prod-preview

@ibuziuk ibuziuk requested a review from Katka92 October 21, 2019 15:20
@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 21, 2019

[test]

@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 21, 2019

tested on dev-cluster and after registries updates the workspace startup seems to work just fine.
test CI is failing though - https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1911/console

Error response from daemon: manifest for quay.io/openshiftio/rhchestage-rh-che-e2e-tests:7.3.0 not found: manifest unknown: manifest unknown
RH-Che test image with tag 7.3.0 found on docker. Reusing image.
Unable to find image 'quay.io/openshiftio/rhchestage-rh-che-e2e-tests:7.3.0' locally
docker: Error response from daemon: manifest for quay.io/openshiftio/rhchestage-rh-che-e2e-tests:7.3.0 not found: manifest unknown: manifest unknown.
See 'docker run --help'.
Running functional tests lasted 25 seconds.
Archiving artifacts from for devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1911
-rw-r--r--. 1 1009 1009 14 Oct 21 16:11 ./artifacts.key
cp: cannot stat ‘./logs/*.log’: No such file or directory
cp: cannot stat ‘./logs/artifacts/screenshots/’: No such file or directory
cp: cannot stat ‘./logs/artifacts/failsafe-reports/’: No such file or directory
sending incremental file list

@Katka92 could you please take a look

@centos-ci
Copy link
Collaborator

@centos-ci
Copy link
Collaborator

ibuziuk and others added 10 commits October 22, 2019 12:21
… in the 'OpenShiftEnvironmentProvisioner'

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@centos-ci
Copy link
Collaborator

@Katka92
Copy link
Collaborator

Katka92 commented Oct 22, 2019

Tests are failing on build&run command, which is a test issue (quick fix is to change command label). The second problem is with LS verification, but when tested manually, it seems like LS is working correctly for Java Maven and Java Vert.x stacks. Approving a merge in this state. I'll provide PR with a fix later.

Copy link
Collaborator

@Katka92 Katka92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are test failures but we agreed to push to prod-preview to unblock keycloak switch verification.

@ibuziuk ibuziuk merged commit 7fdd331 into master Oct 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the ibuziuk-patch-27 branch October 22, 2019 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants