Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

che:theia init should have an option to use local sources instead of cloning the che-theia repo #13738

Closed
sunix opened this issue May 7, 2019 · 2 comments
Closed

che:theia init should have an option to use local sources instead of cloning the che-theia repo #13738

sunix opened this issue May 7, 2019 · 2 comments
Assignees
@evidolob
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone
7.0.0

Comments

@sunix
Copy link
Contributor

sunix commented May 7, 2019 •
edited by benoitf
Loading

Description

Following the work done in eclipse-che/che-theia#45 , when running the command che:theia init, it would be nice to set a local folder to be used instead of cloning the che-theia repo:

che:theia init --alias:github.com/eclipse/che-theia=../che-theia

It would solve the problem some developer are having with CI where they run a build on a PR but the changes are not taken in account because the build is fetching master branch of the same repo

It would also solve some issue when working locally and developer would like to use a local cloned che-theia repo
@sunix sunix self-assigned this Jun 5, 2019
@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added the area/editor/theia Issues related to the che-theia IDE of Che label Jul 5, 2019
@benoitf benoitf mentioned this issue Jul 22, 2019
Closed
@l0rd l0rd added team/ide2 severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Jul 24, 2019
@l0rd l0rd added this to the 7.0.0 milestone Jul 24, 2019
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 24, 2019
@evidolob evidolob mentioned this issue Jul 24, 2019
Closed
18 tasks
@evidolob evidolob assigned evidolob and unassigned sunix Jul 24, 2019
@evidolob evidolob added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 25, 2019
evidolob added a commit to eclipse-che/che-theia that referenced this issue Jul 25, 2019
@evidolob
eclipse-che/che#13738 move che-theia generator to che-theia repository
ce1c93c 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob mentioned this issue Jul 25, 2019
Merged
evidolob added a commit to ws-skeleton/che-theia-generator that referenced this issue Jul 25, 2019
@evidolob
eclipse-che/che#13738 add deprecation notise
605d5ee 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit to eclipse-che/che-theia that referenced this issue Jul 25, 2019
@evidolob
eclipse-che/che#13738 move che-theia generator to che-theia repository
5076732 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@l0rd
Copy link
Contributor

l0rd commented Jul 29, 2019

@evidolob now that eclipse-che/che-theia#369 has been merged can we close this issue or is there something missing?

@benoitf
Copy link
Contributor

benoitf commented Jul 29, 2019

PR was merged during the move

@benoitf benoitf closed this as completed Jul 29, 2019
evidolob added a commit to eclipse-che/che-theia that referenced this issue Jul 30, 2019
@evidolob
eclipse-che/che#13738 Include current che-theia sources
08e2c36 
during docker image build

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob mentioned this issue Jul 30, 2019
Merged
evidolob added a commit to eclipse-che/che-theia that referenced this issue Jul 31, 2019
@evidolob
Use current che-theia sources for docker image build (#384)
e2d1f85 
* eclipse-che/che#13738 Include current che-theia sources
during docker image build

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Remove un needed docker cache invalidation

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Fix review comments

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Remove changes

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* use ADD instead of COPY,
 make shure that git ls-files are run from rigth context

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob mentioned this issue Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@benoitf @l0rd @sunix @evidolob