Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single-host/default-host in multi-user server mode #14189

Closed
metlos opened this issue Aug 9, 2019 · 3 comments
Closed

Support single-host/default-host in multi-user server mode #14189

metlos opened this issue Aug 9, 2019 · 3 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@metlos
Copy link
Contributor

metlos commented Aug 9, 2019

Is your task related to a problem? Please describe.

During the spike #14002, we've identified the issues with single-host mode (where workspaces are exposed using the host name of the Che server on unique subpaths) on Kubernetes (we don't support this mode at all on Openshift).

PR #14134, developed during the spike investigation, fixes the support for single-host and default-host exposure strategies in the single-user mode.

We need to support single-host also in multi-user mode but that is unfortunately more complex.

There seems to be a problem with exposing the servers in the multiuser mode. Both secured (proxied by jwt proxy) and non-secured servers (e.g. exposed components) seem to be created or at least queried incorrectly, resulting in failed startup with the message:

Error: Workspace doesn't have a server which matches with URL: http://192.168.99.121.nip.io/?uid=558503

Notice the URL that doesn't really make sense.

Referenced Issues

This issue stems from the spike #14002 and blocks #12971.

@metlos metlos added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Aug 9, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 9, 2019
@skabashnyuk skabashnyuk added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 9, 2019
@skabashnyuk skabashnyuk added this to the 7.1.0 milestone Aug 9, 2019
@skabashnyuk skabashnyuk modified the milestones: 7.1.0, 7.2.0 Aug 14, 2019
@skabashnyuk skabashnyuk modified the milestones: 7.2.0, 7.1.0 Aug 27, 2019
@sleshchenko sleshchenko added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Aug 28, 2019
@sleshchenko
Copy link
Member

sleshchenko commented Aug 29, 2019

I think closing if this issue also mean solving #12971
@metlos Can you confirm?

@metlos
Copy link
Contributor Author

metlos commented Aug 30, 2019

I think closing if this issue also mean solving #12971
@metlos Can you confirm?

Yes, that issue exactly describes the problems that we're solving here.

@metlos
Copy link
Contributor Author

metlos commented Sep 10, 2019

#14335 is merged.

@metlos metlos closed this as completed Sep 10, 2019
@tolusha tolusha removed the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants