Add the missing dockerimage component endpoint attributes to the devfile reference #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
approved these changes
Aug 30, 2019
rkratky
suggested changes
Aug 30, 2019
rkratky
approved these changes
Sep 3, 2019
|
Hi @metlos. The changes that you have committed from GitHub Web UI have been attributed to an email address that cannot be covered by necessary legal agreements (metlos@****.noreply). You should amend your commits to fix the email address in the commit. |
Co-Authored-By: Robert Krátký <rkratky@redhat.com>
metlos
force-pushed
the
endpoint-attributes
branch
from
8f6395e
to
b1bedd0
Compare
|
I've re-authored the commit and force pushed into the branch so that the license checks pass. Thanks for pointing out the problem to me @themr0c. |
|
Thank you for the contribution, and thank you for your hard work fixing the license check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
$TITLEWhat issues does this PR fix or reference?
I've discovered this while investigating the docs for workspace exposure strategies (eclipse-che/che#14189)