Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build theia-endpoint-runtime because of an API breakage on Theia 0.10.x-next #14273

Closed
1 task done
monaka opened this issue Aug 19, 2019 · 3 comments
Closed
1 task done

Can't build theia-endpoint-runtime because of an API breakage on Theia 0.10.x-next #14273

monaka opened this issue Aug 19, 2019 · 3 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system.
Milestone
7.1.0

Comments

@monaka
Copy link
Member

monaka commented Aug 19, 2019 •
edited
Loading

Describe the bug

I couldn't build Che-theia. I can't show how to reproduce because my build environment is customized.
But the root cause is obvious.
getPluginDependencies is not added to PluginDeployerHandlerImpl even though it was added to PluginDeployerHandler (ref: eclipse-theia/theia@2d4c845#diff-2a5766562161792548814f3e490b89ffR613-R614 )

Che-Theia version

  • other: please specify (master branch with some patches.)

Steps to reproduce

Expected behavior

Builds finish with no error.

Additional context

packages/theia-remote/src/node/plugin-remote-init.ts(290,7): error TS2420: Class 'PluginDeployerHandlerImpl' incorrectly implements interface 'PluginDeployerHandler'.
  Property 'getPluginDependencies' is missing in type 'PluginDeployerHandlerImpl'.

My build log is https://dev.azure.com/pizzafactory/camino/_build/results?buildId=1229
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 19, 2019
@monaka monaka added the area/editor/theia Issues related to the che-theia IDE of Che label Aug 19, 2019
@monaka monaka modified the milestones: 7.x, 7.1.0 Aug 19, 2019
@monaka
Copy link
Member Author

monaka commented Aug 19, 2019

This might be fixed by eclipse-che/che-theia#406 ?

@rhopp rhopp added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 19, 2019
@rhopp
Copy link
Contributor

rhopp commented Aug 19, 2019

@evidolob I've set P1 for this issue. Do you think your PR will resolve this one?

@monaka
Copy link
Member Author

monaka commented Aug 21, 2019

It looks to be fixed by eclipse-che/che-theia#409. I close it.

@monaka monaka closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.1.0
Development

No branches or pull requests
3 participants
@monaka @rhopp @che-bot