Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use same version of @theia dependencies in 'che-theia' and 'che-theia-endpoint-runtime' #406

Closed
wants to merge 4 commits into from

Conversation

evidolob
Copy link
Contributor

@evidolob evidolob commented Aug 12, 2019

What does this PR do?

Use same version of @Theia dependencies in 'che-theia' and 'che-theia-endpoint-runtime'

Note: this fix for 7.0.0 branch, better solution should be after #13387

What issues does this PR fix or reference?

eclipse-che/che#14187

dependencies in 'che-theia' and 'che-theia-endpoint-runtime' images

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup may occur in master branch

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob
Copy link
Contributor Author

During test @tolusha found:

{ Error: Cannot find module '/home/theia/node_modules/@eclipse-che/theia-plugin-ext/lib/plugin/node/che-api-node-provider.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.initExtApi (/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/plugin-host-rpc.js:208:50)
    at PluginManagerExtImpl.<anonymous> (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-manager.js:137:39)
    at step (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-manager.js:47:23)
    at Object.next (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-manager.js:28:53)
    at /home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-manager.js:22:71
    at new Promise (<anonymous>) code: 'MODULE_NOT_FOUND' }

Going to fix that error

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Aug 14, 2019

@evidolob
With the latest commit I haven't found any regressions.
Php, Go and Python plugins were tested.

@evidolob evidolob added this to the 7.1.0 milestone Aug 14, 2019
@dmytro-ndp
Copy link
Contributor

@evidolob: we are encountered an error
69-Wait workspace running state-(9_48_59_956)
when running nightly Che with Theia from master branch on K8S.

@evidolob
Copy link
Contributor Author

@dmytro-ndp And how it related to this PR?

@dmytro-ndp
Copy link
Contributor

@evidolob: you are right, your PR is not related to the error I showed. I misunderstood the topic and target branch.
Sorry for that.

@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@evidolob evidolob closed this Nov 20, 2019
@evidolob evidolob deleted the fix-remote-runtime-build branch February 27, 2020 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants