Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update remote-plugin-openshift-connector to odo 1.0 and oc 4.1 #14287

Closed
nickboldt opened this issue Aug 19, 2019 · 6 comments
Closed

Update remote-plugin-openshift-connector to odo 1.0 and oc 4.1 #14287

nickboldt opened this issue Aug 19, 2019 · 6 comments
Assignees
@azatsarynnyy
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.3.0

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Aug 19, 2019 •
edited
Loading

Is your enhancement related to a problem? Please describe.

Looking at https://github.com/eclipse/che-theia/blob/master/dockerfiles/remote-plugin-openshift-connector-0.0.21/Dockerfile#L26-L29 ...

Describe the solution you'd like

Should we update https://github.com/eclipse/che-theia/blob/master/dockerfiles/remote-plugin-openshift-connector-0.0.21/Dockerfile to a newer version of odo, and the v4.1 version of oc?

Describe alternatives you've considered

Not updating anything and testing to see if openshift connector plugin works with OCP4/OSD4 first?

Additional context

Productized Che 7 (CRW 2) has to support OCP 4.2 and OSD 4.2 as a deployment environment, but I don't know if that also means supporting interacting w. Openshift 4 from WITHIN Che/CRW via this plugin.

Seems like a logical next step, but maybe that's a goal for 2.1 (Che 7.7?), not 2.0 (Che 7.3?) ?

cc: @l0rd @slemeur @benoitf
@nickboldt nickboldt added kind/enhancement A feature request - must adhere to the feature request template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 19, 2019
@nickboldt nickboldt changed the title Update remote-plugin-openshift-connector to odo 1.0 and oc 4 Update remote-plugin-openshift-connector to odo 1.0 and oc 4.1 Aug 19, 2019
@nickboldt
Copy link
Contributor Author

Note:

latest odo: https://github.com/openshift/odo/releases (1.0.0-beta4)
latest oc: https://mirror.openshift.com/pub/openshift-v4/clients/ocp/ (4.1.12)

@ibuziuk ibuziuk added team/ide and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 26, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 26, 2019

@l0rd @evidolob I have removed the need-triage label since we just need to decide in which milestone are we planning to update the odo and oc binaries

@vparfonov vparfonov mentioned this issue Sep 18, 2019
Closed
25 tasks
@vparfonov
Copy link
Contributor

will be fixed in #14287

@l0rd l0rd added this to the Backlog - IDE 1 milestone Sep 23, 2019
@vparfonov vparfonov added the severity/P1 Has a major impact to usage or development of the system. label Sep 23, 2019
@azatsarynnyy azatsarynnyy self-assigned this Sep 25, 2019
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 25, 2019
@azatsarynnyy
Copy link
Member

azatsarynnyy commented Oct 1, 2019 •
edited
Loading

I've tested the current version of OpenShift Connector Che Plugin with OCP 4 and looks like it works well, at first glance...
image

But during some operations, I've got the messages about incompatibility, e.g.
image

Also, looks like the current Che Plugin creates the cluster resources in OpenSHift 3.x format. When connecting to the OCP 4 cluster with the latest version of OpenShift Connector extension from VS Code, it notifies:
image

So, I'm going to update the Che Plugin to the latest version of the corresponded VS Code extension + its dependencies.

@vparfonov vparfonov modified the milestones: Backlog - IDE 1, 7.3.0 Oct 2, 2019
@azatsarynnyy azatsarynnyy mentioned this issue Oct 3, 2019
Merged
@azatsarynnyy
Copy link
Member

The latest version of OpenShift Connector VS Code extension requires oc version >= 3.11.0 and < 4.0.0.
With oc > 4.0.0 extension proposes to downgrade it
os-oc

So, I'll keep oc v3.11.0
See eclipse-che/che-theia#465

@azatsarynnyy
Copy link
Member

Done in eclipse-che/che-theia#465 + eclipse-che/che-plugin-registry#238

@azatsarynnyy azatsarynnyy removed the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.3.0
Development

No branches or pull requests
5 participants
@nickboldt @l0rd @ibuziuk @azatsarynnyy @vparfonov