[Plugin Registry] [airgap] Each plugin should display proper icon

[vitaliy-guliy]

Is your enhancement related to a problem? Please describe.

On the plugin registry each plugin refers on the same default icon. When displaying them on the UI, it looks not pretty nice

Describe the solution you'd like

We can apply the proper icons for each plugin.
Most of the plugins are VS Code extensions. Most of them are opensource with repository on GitHub. Each extension has package.json contains icon field which refers on the image hosted on that repository. We can easily refers on that images.

In result we may have the following

[tolusha]

What about licensing?

[vitaliy-guliy]

Licensing of what?

[slemeur]

@vitaliy-guliy : I guess question from @tolusha is more about are we authorized to pull the images this way. I guess that if we are pulling from the repository it is fine.

Another aspect is how this would work if you are behind a proxy and can't reach github? Would it not be better to have that in the meta.yaml and directly in the plugin registry?

[nickboldt]

See also #15581 re: icons in devfiles

[nickboldt]

Another aspect is how this would work if you are behind a proxy and can't reach github? Would it not be better to have that in the meta.yaml and directly in the plugin registry?

Yes, icons should be cacheable inside the registry, just like .vsix files.

[sunix]

hello @vitaliy-guliy do you have any plans to implement that ?

[sunix]

Hello, first step, let's have the icons in the plugin registry like we do for devfile registry https://github.com/eclipse/che-devfile-registry/tree/master/images.
We will figure out later about a way to get that from the package.json.

[amisevsk]

The blocker issue for this is in how these images are retrieved; unless we want to ensure relative links are supported everywhere a plugin icon might be displayed, #15091 needs to be resolved before we throw icons into the registry.

[vitaliy-guliy]

@sunix why not to point on the image on plugin repository on GitHub?
Something like this
https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/ms-kubernetes-tools/vscode-kubernetes-tools/1.0.9/meta.yaml#L9

For each plugin we specify its source repository, which almost always contains the plugin logo.

[sunix]

@vitaliy-guliy ok what ever, as long as this is working :)

[ericwill]

This was fixed in 7.18 but was never closed.

[vitaliy-guliy]

Thanks