Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfiles from devfile registry should provide right icon instead of default Che one #15581

Closed
sleshchenko opened this issue Dec 27, 2019 · 9 comments
Assignees
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sleshchenko
Copy link
Member

Is your task related to a problem? Please describe.

Get Started page is coming and using default Che icon for every devfile becomes an issue:
get-started

Describe the solution you'd like

Devfile Registry must provide the right icons for every devfile.

@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. area/devfile-registry labels Dec 27, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 27, 2019
@sleshchenko
Copy link
Member Author

cc @l0rd @slemeur @tsmaeder

@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. team/controller and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 27, 2019
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. kind/enhancement A feature request - must adhere to the feature request template. and removed severity/P1 Has a major impact to usage or development of the system. team/controller kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jan 9, 2020
@beaumorley
Copy link

Here is mockup Get Started with the proposed icons for the various devfiles. If anyone has a better suggestion for any of them, let me know and I can make another logo.

onboarding_page_logo_placement_updated

And here is a zip file with the logos.

final_logos.zip

And here is a table with the devfile matched to the logo name.

dev file logo img name
angular angular.svg
apache-camel-k camel.sgv
apache-camel-springboot camel.sgv
che4z che.svg
cpp cpp.svg
dotnet-asp.net dotnet.svg
dotnet dotnet.svg
go go.svg
java-gradle java.svg
java-maven java.svg
java-mongo java.svg
java-mysql java.svg
java-web-spring springboot.svg
java-web-vertx vertx.svg
nodejs-mongo nodejs.svg
nodejs-react nodejs.svg
nodejs-yarn nodejs.svg
nodejs nodejs.svg
php-laravel php.svg
php-mysql php.svg
php-symfony php.svg
php-web-simple php.svg
python-django php.svg
python-django python.svg
quarkus quarkus.svg
rust rust.svg

I have a master file for the logos. Easy to tweak them in anyone has any feedback!

@beaumorley
Copy link

Also, would it be possible to align the title at the top left (Getting Started with Eclipse Che) with the search control on the right? Like this?

image

@sleshchenko
Copy link
Member Author

@beaumorley Thanks a lot for providing needed icons for each of devfiles. Could you confirm that they're our own icons and we can put Eclipse License there?

But there is still an open question: who should serve these icons? Currently, Devfile Registry does not serve icons at all, there are the corresponding issues which can make it possible:
Devfile Registry Should Serve Pictures #14844
Registries should be provisioned with their public URL by default #15091
@slemeur @l0rd @nickboldt Do we have a chance to prioritize these issues or we can like start with putting these resources into Che Docs site and reference them from Devfile Registry then?

@olexii4
Copy link
Contributor

olexii4 commented Jan 11, 2020

Also, would it be possible to align the title at the top left (Getting Started with Eclipse Che) with the search control on the right? Like this?

@beaumorley The issue description has a bit outdated example, now a page looks like the following:
Screenshot from 2020-01-11 13-49-40

Is it good enough?

@beaumorley
Copy link

beaumorley commented Jan 13, 2020

I looked up licensing on all. It looks like the only ones that may be an issue are java and .NET. However, the java logo is being used on Eclipse.org/che and .NET is being used on OpenShift. I will look into these. Here are my notes on licensing for the record.

icon copyright OK copyright info license info notes notes
angular.svg YES Creative Commons license https://angular.io/presskit    
camel.svg YES apache https://github.com/apache/camel-k/blob/master/LICENSE    
che.svg YES Eclipse Foundation      
cpp.svg YES standard c++ foundation https://isocpp.org/home/terms-of-use    
dotnetcore.svg ? .NET Foundation https://www.asp.net/terms-of-use already in OpenShift This one may need to be verified
go_new.svg YES Creative Commons license https://blog.golang.org/go-brand already in OpenShift New logo!
java.svg ? Oracle Java Licensing http://www.oracle.com/us/technologies/java/java-licensing-logo-guidelines-1908204.pdf already in OpenShift This one may need to be verified
mainframe.svg YES Linux Foundation trademark usage guidelines https://github.com/openmainframeproject/artwork    
nodejs.svg YES Node.js Foundation https://nodejs.org/static/documents/trademark-policy.pdf already in OpenShift  
php.svg YES PHP License https://www.php.net/download-logos.php already in OpenShift  
python.svg YES Phython Foundation https://www.python.org/community/logos/ already in OpenShift  
quarkus YES Red Hat      
rust.svg YES creative commons license https://www.rust-lang.org/policies/media-guide    
springboot.svg YES Pivotal https://spring.io/trademarks    
vertx.svg YES Eclipse Public License https://github.com/eclipse-vertx/vert.x/blob/master/LICENSE.md    

@beaumorley
Copy link

Also, there is a new Go logo. Can you can replace the original one I gave you with this one? Realized this when I read the licensing. Thank you.

go_new.svg.zip

@beaumorley
Copy link

beaumorley commented Jan 13, 2020 via email

@beaumorley
Copy link

Hello team,

While verifying the licensing on the .NET and Java logos, I learned that the correct logo for .NET Core is a purple coin with .NET Core inside. Please replace the dotnet.svg logo I already provided with this new dotnetcore.svg.

dotnetcore.svg.zip

Thank you,
Beau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants