Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve relative links to icons on Create Workspace page #15832

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Resolves relative icons links on Create Workspace page:
Screenshot_20200127_125625

What issues does this PR fix or reference?

Part of #15581

Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@centos-ci
Copy link

Can one of the admins verify this patch?

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jan 27, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 27, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@sleshchenko sleshchenko changed the title Resolve relative icons links on Create Workspace page Resolve relative links to icons on Create Workspace page Jan 27, 2020
@sleshchenko sleshchenko merged commit 9ce61ff into eclipse-che:master Jan 27, 2020
@sleshchenko sleshchenko deleted the dashboardIcons branch January 27, 2020 11:33
@che-bot che-bot added this to the 7.8.0 milestone Jan 27, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 27, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 27, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants