Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Devconsole integration #14745

Closed
l0rd opened this issue Oct 2, 2019 · 7 comments
Closed

Verify Devconsole integration #14745

l0rd opened this issue Oct 2, 2019 · 7 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 2, 2019

Is your enhancement related to a problem?

OCP 4.2 DevConsole has integration with Che:

  • A Che Console Link
  • A link to a factory URL to create the

Describe the solution you'd like

We should test that when a Che 7.2 or higher (with TLS enabled) is installed on OCP 4.2:

  • Che console link is created
  • A factory link in the DevConsole topology triggers the successful creation of a workspace
  • Clicking a second time on the factory link opens the existing workspace
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 2, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 2, 2019
@benoitf benoitf added this to the Backlog - Platform milestone Oct 2, 2019
@benoitf benoitf added team/che-qe and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. team/platform labels Oct 2, 2019
@benoitf benoitf added the severity/P2 Has a minor but important impact to the usage or development of the system. label Oct 2, 2019
@skabashnyuk
Copy link
Contributor

skabashnyuk commented Oct 4, 2019

@l0rd
Copy link
Contributor Author

l0rd commented Oct 7, 2019

Please verify that policies.create=peruser works as expected as well.

@l0rd
Copy link
Contributor Author

l0rd commented Oct 7, 2019

As discussed with the team this issue is assigned to team/platform and should be included in 7.3 milestone. Of course QE team can add a corresponding automated test but that's not what this issue is about and we can close this issue as soon as platform team as finished its verification.

@sleshchenko
Copy link
Member

I successfully verified that Che link appeared on Dev Console and there is an ability to edit source code, but I failed to run workspace because of my laptop performance issues.
Previously I run OpenShift 4.x with 10Gi and it was enough for Che with 1 workspace, now seems it's not enough.
Tried with 14Gi - but it leads to issue with Linux which causes VM crashing.
Trying with 12Gi... If it fails - I will try to request AWS resources.

@davidfestal
Copy link
Contributor

How would be the CRW case managed in terms of ConsoleLink ?
does this issue also cover this question ?

Afaict, the mentioned PR doesn't seem to provide a way to override the name, display name and icon of the provided ConsoleLink.

Is it expected that Che branding is always shown from the devConsole even though CRW is installed ?

cc @l0rd @nickboldt

@sleshchenko
Copy link
Member

sleshchenko commented Oct 8, 2019

Successfully requested OpenShift 4.2 on AWS and tested ConsoleLink workflow.
Faced the following issue: Dashboard handles incorrectly cases when policies.create=perUser is specified and there is already Running or Starting workspace #14554
cc @l0rd it might need to be prioritized

P.S. Screencast of a console link workflow
console_link

@sleshchenko
Copy link
Member

sleshchenko commented Oct 15, 2019

Che&Devconsole integration is retested after #14554 is closed:

Subject Comment
Red Hat Applications ✔️ Che appears in Red Hat Applications tab
Click Edit Source Code when no any workspace is running ✔️ The wanted workspace is started and opened
Click Edit Source Code when there is running workspace for this requested project ✔️ The wanted workspace is opened
Click Edit Source Code when there is starting workspace for this requested project ✔️ The wanted workspace is opened and a crane shows start process
Click Edit Source Code when there is running workspace for another project ✔️ Dashboard shows error message You are not allowed to start more workspaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

8 participants