Dynamically generate che workspace factory URL in Topology after getting cheURL from ConsoleLink CR #2536
Conversation
openshift-ci-robot
added
the
size/M
|
/kind bug |
openshift-ci-robot
added
kind/bug
| 'app.openshift.io/vcs-ref': ref, | ||
| 'app.openshift.io/vcs-ref': gitRef || 'master', | ||
| ...(cheURL && { | ||
| 'app.openshift.io/edit-url': `${cheURL}/f?url=${gitURL}&policy.create=peruser`, |
There was a problem hiding this comment.
can we change policy.create to policys.create ? To match eclipse-che/che#14355 ?
There was a problem hiding this comment.
Sure, will update the code.
| 'app.openshift.io/vcs-ref': ref, | ||
| 'app.openshift.io/vcs-ref': gitRef || 'master', | ||
| ...(cheURL && { | ||
| 'app.openshift.io/edit-url': `${cheURL}/f?url=${gitURL}&policys.create=peruser`, |
There was a problem hiding this comment.
Updated. policys is what you mentioned in your earlier comment.
There was a problem hiding this comment.
I'm sorry. I was wrong. policies is the correct query name
…ing cheURL from ConsoleLink CR
rohitkrai03
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR -
ConsoleLinkCR which will be created byEclipse CheOperator and will haveChe DashboardURL.ConsoleLinkwe generate a Che Factory URL that will take the user through the workspace creation process.Che URLdynamically addsEdit URLon topology nodes.