Factory policies.create=peruser

[skabashnyuk]

Is your task related to a problem? Please describe.

Provide an ability to create workspaces from factories per user.

Describe the solution you'd like

The idea is to have a query parameter policies.create=peruser like http://host/f?url=blah&policies.create=peruser that will cause only one workspace to be generated for each unique user that clicks on the factory URL. If the workspace has previously been generated, the existing workspace is reopened.

Describe alternatives you've considered

none

Additional context

Che6 persisted factory feature https://www.eclipse.org/che/docs/che-6/factories_json_reference.html#policies

[tolusha]

may be create?

[sunix]

Has that issue been 'triaged' ?

[sunix]

@skabashnyuk Is it a issue for platform team ? or do we have anything to do in the Dashboard or che-theia side

[skabashnyuk]

@sunix this task is for the team who has more expertise in the dashboard. I think it is ide2.

[skabashnyuk]

As I remember I've discussed this task with @evidolob, I thought he wants to delegate it to @olexii4
Basic idea is to handle this logic on the Dashboard side.

• Check if policies.create=peruser set
• if yes -> iterate over all workspaces searching for attribute "factoryurl" = to current query URL
  • if found redirect to that workspace
  • if not create a new workspace and set "factoryurl" attribute.

[sunix]

I thought factory service wasn't aware of the dashboard ? @olexii4 ?

[vitaliy-guliy]

@skabashnyuk and me have a discussion about workspace creation flow using a factory.

http://host/f?url=blah&policies.create=peruser just redirects on http://host//dashboard/#/load-factory/?url=blah&policies.create=peruser and then dashboard creates a workspace using factory and workspace services.

@sunix yes, it looks IDE2 team is responsible for this issue

To have the issue done we need

• ensure that query parameter policies.create=peruser is passed to the dashboard
• add a property to the workspace settings/attributes that indicates from which URI this workspace has been created
• while handling a factory in dashboard, find for already existing workspace if query parameter policies.create=peruser is set

[sunix]

ok, thanks @vitaliy-guliy and @skabashnyuk for the details

[olexii4]

@skabashnyuk We can create a new workspace with URL http://host/f?url=location.
that will create a new workspace with attributes.factoryId = 'undefined' because any factories are not supported at all.
If I am not mistaken, nowadays we cannot create a new factory based on a devfile.
Could we use attributes.stackName=locationl instead?

[skabashnyuk]

@olexii4 I'm not sure I understand your question. Can you rephrase?
My proposal was #14355 (comment).
attributes.factoryId this is for old Che6 persisted factories. It's not our case.

[olexii4]

@skabashnyuk I just confused with the word 'factory'. I thought about CHE factories.
All are clear now.