Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vale vscode plugin to the plugin registry #15856

Closed
amisevsk opened this issue Jan 28, 2020 · 6 comments
Closed

Add Vale vscode plugin to the plugin registry #15856

amisevsk opened this issue Jan 28, 2020 · 6 comments
Labels
area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@amisevsk
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

To support the case of building Che docs in a Che workspaces, it would be very helpful to have the Vale vscode plugin available in the plugin registry.
@amisevsk amisevsk added kind/enhancement A feature request - must adhere to the feature request template. area/plugin-registry labels Jan 28, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 28, 2020
@nickboldt
Copy link
Contributor

@mkuznyetsov another 3rd party candidate for building https://github.com/testthedocs/vscode-vale/releases/download/0.9.0/vale-0.9.0.vsix (but not needed in CRW yet, so only if you need another test case for your user doc)

@nickboldt nickboldt mentioned this issue Jan 28, 2020
Merged
@ericwill
Copy link
Contributor

I think this is a good candidate for our next sprint.

@ericwill ericwill mentioned this issue Jan 28, 2020
Closed
12 tasks
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. team/plugins and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 28, 2020
@themr0c themr0c mentioned this issue Jan 29, 2020
Closed
16 tasks
@ericwill
Copy link
Contributor

@themr0c do you have any specific configuration preferences for Vale? Should I add the config files from eclipse-che/che-docs#1057 into the Vale config in the sidecar container?

ericwill added a commit to ericwill/che-sidecar-vale that referenced this issue Feb 4, 2020
@ericwill
Add Dockerfile for the vale plugin.
307bc53 
See eclipse-che/che#15856

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Feb 4, 2020
Merged
ericwill added a commit to ericwill/che-sidecar-vale that referenced this issue Feb 5, 2020
@ericwill
Add Dockerfile for the vale plugin.
0272b2d 
See eclipse-che/che#15856

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Feb 5, 2020
Merged
ericwill added a commit to ericwill/che-sidecar-vale that referenced this issue Feb 11, 2020
@ericwill
Fix asciidoc support
f550151 
Add the asciidoctor package to the vale sidecar container. If it's not installed,
vale will look for it and return an error.

See eclipse-che/che#15856

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Feb 11, 2020
Merged
ericwill added a commit to ericwill/che-sidecar-vale that referenced this issue Feb 11, 2020
@ericwill
Fix asciidoc support
9db10bf 
Add the asciidoctor package to the vale sidecar container. If it's not installed,
vale will look for it and return an error.

See eclipse-che/che#15856

Signed-off-by: Eric Williams <ericwill@redhat.com>
@amisevsk
Copy link
Contributor Author

Fixed by eclipse-che/che-plugin-registry#375

amisevsk pushed a commit to eclipse-che/che-plugin-registry that referenced this issue Feb 12, 2020
@ericwill @amisevsk
Add Vale to the Che Plugin Registry
0d1ea6e 
Initial contribution of the vscode-vale extension to the Che Plugin Registry.
The sidecar container for this extension contains a basic Vale config file.

See eclipse-che/che#15856

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill
Copy link
Contributor

I think this one can be closed now.

@themr0c
Copy link
Contributor

themr0c commented Feb 17, 2020

@ericwill I believe the config for vale should always be defined by the project you are checking.

monaka pushed a commit to PizzaFactory/che-plugin-registry that referenced this issue Mar 7, 2020
@ericwill @monaka
Add Vale to the Che Plugin Registry
e59629d 
Initial contribution of the vscode-vale extension to the Che Plugin Registry.
The sidecar container for this extension contains a basic Vale config file.

See eclipse-che/che#15856

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nickboldt @themr0c @l0rd @ericwill @amisevsk @che-bot