Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About dialog is broken #15962

Closed
4 of 23 tasks
RomanNikitenko opened this issue Feb 7, 2020 · 9 comments · Fixed by eclipse-che/che-theia#649
Closed
4 of 23 tasks

About dialog is broken #15962

RomanNikitenko opened this issue Feb 7, 2020 · 9 comments · Fixed by eclipse-che/che-theia#649
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.10

Comments

@RomanNikitenko
Copy link
Member

Describe the bug

About dialog looks strange, please see the screenshot.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Go to Help => About menu
  2. Pay attention how the dialog looks.
  3. Try to refresh a page and go to Help => About menu again.
  4. Pay attention how the dialog looks.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

help_about
help_about2

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/theia Issues related to the che-theia IDE of Che labels Feb 7, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 7, 2020
@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 7, 2020
@skabashnyuk skabashnyuk mentioned this issue Feb 12, 2020
Closed
3 tasks
@benoitf
Copy link
Contributor

benoitf commented Feb 12, 2020

funny thing: closing/reopening about menu is fixing space issue.

@RomanNikitenko
Copy link
Member Author

The issue can be related to the changes in theia repo eclipse-theia/theia@5034fbe

@benoitf benoitf mentioned this issue Feb 18, 2020
Closed
23 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Feb 19, 2020
Closed
16 tasks
@nickboldt
Copy link
Contributor

This is even worse when whitelabelled as CRW:

image

@nickboldt nickboldt added area/productization severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Mar 2, 2020
@nickboldt
Copy link
Contributor

Escalating to blocker. Something this obviously broken/ugly cannot slip into product.

Please fix for 7.9.1 if possible.

@nickboldt nickboldt added this to the 7.10.0 milestone Mar 2, 2020
@nickboldt nickboldt mentioned this issue Mar 2, 2020
Closed
24 tasks
@nickboldt
Copy link
Contributor

To be clear there are 3 issues here but one of them might be downstream (not sure if it's a whitelabel coding problem or a missing image in downstream):

  • 2 lists of extensions (one empty ABOVE the logo, one populated BELOW the logo)
  • 2 "Ok" buttons (left one does nothing, right one closes the dialog as expected)
  • broken CRW icon

@nickboldt nickboldt removed the severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. label Mar 2, 2020
@nickboldt
Copy link
Contributor

I've been told to not call this a blocker so removing that label. But it's still a priority/P1 if not a severity/S1.

@azatsarynnyy azatsarynnyy mentioned this issue Mar 3, 2020
Merged
@nickboldt nickboldt mentioned this issue Mar 4, 2020
Closed
27 tasks
@nickboldt
Copy link
Contributor

This appears to be commit in 7.9.x that fixes the same problem in 7.9.0 / master:

eclipse-che/che-theia@13070ca
https://github.com/eclipse/che-theia/pull/649/files

(It's fun when the commit messages don't line up.) :D

@nickboldt nickboldt reopened this Mar 17, 2020
@nickboldt
Copy link
Contributor

Dmytro reports problem not fixed in downstream issue:

https://issues.redhat.com/browse/CRW-674?focusedCommentId=14001032&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14001032

So reopening.

@benoitf
Copy link
Contributor

benoitf commented Mar 17, 2020 •
edited
Loading

It's already fixed upstream so I don't see why it needs to be opened there
image

@benoitf benoitf closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.10
Development

Successfully merging a pull request may close this issue.

Rework About dialog with React according to the upstream changes eclipse-che/che-theia
5 participants
@nickboldt @benoitf @tolusha @RomanNikitenko @che-bot