Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Rework About dialog with React according to the upstream changes #649

Merged
merged 7 commits into from
Mar 4, 2020
Merged

Rework About dialog with React according to the upstream changes #649

merged 7 commits into from
Mar 4, 2020

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Mar 3, 2020 •
edited
Loading

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Reworks About dialog with React according to the upstream changes

image

What issues does this PR fix or reference?

closes eclipse-che/che#15962

Release Notes

Docs PR

@azatsarynnyy
Update About dialog according to the upstream changes: disable React …
f7a72a9 
…rendering as we're doing the manipulations directly contentNode

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Update About dialog according to the upstream changes: disable React …
b4485d4 
…rendering as we're doing the manipulations directly contentNode

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@RomanNikitenko
Copy link
Member

@azatsarynnyy
I tested your changes using che-in-che development.
It works well except one use case:

help_about

Can you reproduce it on your side?

@azatsarynnyy
Copy link
Member Author

@RomanNikitenko yes, I can reproduce it.
Thanks a lot for the thorough testing! 👍
Working on it...

@azatsarynnyy
Update About dialog according to the upstream changes: disable React …
85beca2 
…rendering as we're doing the manipulations directly contentNode

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Copy link
Member Author

Reworked with the React rendering to comply with the upstream About dialog which we extend.

@azatsarynnyy
Update About dialog according to the upstream changes: disable React …
7256625 
…rendering as we're doing the manipulations directly contentNode

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Update About dialog according to the upstream changes: disable React …
e7a76f8 
…rendering as we're doing the manipulations directly contentNode

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 3, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:649
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:649

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy azatsarynnyy changed the title Update About dialog according to the upstream changes Rework About dialog with React according to the upstream changes Mar 4, 2020
@azatsarynnyy
Copy link
Member Author

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Mar 4, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Mar 4, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Mar 4, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Mar 4, 2020
@RomanNikitenko RomanNikitenko self-requested a review March 4, 2020 08:54
RomanNikitenko
RomanNikitenko approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes after update - Looks good to me!

about

@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:649
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:649

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

Happy path are failed on Validation of workspace build and run step.
That is a known issue related to https mode.
Since the changes don't touch run/debug application functionality, we're merging the PR.

@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:649
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:649

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

[ci-build]

@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:649
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:649

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy azatsarynnyy merged commit c7c05ac into master Mar 4, 2020
@azatsarynnyy azatsarynnyy deleted the update-about branch March 4, 2020 19:04
@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:649
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:649

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:649
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:649

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vzhukovs vzhukovs vzhukovs approved these changes

@RomanNikitenko RomanNikitenko RomanNikitenko approved these changes

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About dialog is broken
4 participants
@azatsarynnyy @RomanNikitenko @che-bot @vzhukovs