Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace related commands should be consistent with Che #17106

Closed
4 tasks done
azatsarynnyy opened this issue Jun 5, 2020 · 6 comments
Closed
4 tasks done

Workspace related commands should be consistent with Che #17106

azatsarynnyy opened this issue Jun 5, 2020 · 6 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Jun 5, 2020

Is your enhancement related to a problem? Please describe.

Che Theia provides a set of commands that are related to Theia Workspace which is similar to VS Code Workspace.
image

While the experienced VS Code users are pretty familiar with this Workspace concept, it differs from Che Workspace. That may confuse the existing Che users as the behavior of these commands is inconsistent with Che Workspace.

At the same time, it makes sense to have these Workspace commands providing functionality related to Che Workspaces.

Describe the solution you'd like

Replace Theia Workspace commands with Che Workspace commands.

Describe alternatives you've considered

Find a good name replacement for Theia Workspaces related commands to resume them.

cc @benoitf @l0rd

@azatsarynnyy azatsarynnyy added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che labels Jun 5, 2020
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jun 8, 2020
@azatsarynnyy
Copy link
Member Author

I was thinking about a good replacement for Theia's Workspace term, e.g.:

  • Workspace Roots
  • Root Folders
  • Root Folders Layout
  • etc.

I'd like to use Workspace Roots.
So, to keep the existing commands I propose to rename them as follows:

  • Open Workspace Roots...
  • Open Recent Workspace Roots...
  • Save Workspace Roots As...
  • Close Workspace Roots

@benoitf @l0rd WDYT?

@azatsarynnyy
Copy link
Member Author

linked with the separate issues

@azatsarynnyy azatsarynnyy mentioned this issue Jun 25, 2020
20 tasks
@l0rd
Copy link
Contributor

l0rd commented Jun 25, 2020

I was thinking about a good replacement for Theia's Workspace term, e.g.:

  • Workspace Roots
  • Root Folders
  • Root Folders Layout
  • etc.

I'd like to use Workspace Roots.
So, to keep the existing commands I propose to rename them as follows:

  • Open Workspace Roots...
  • Open Recent Workspace Roots...
  • Save Workspace Roots As...
  • Close Workspace Roots

@benoitf @l0rd WDYT?

I like the proposal @azatsarynnyy

@sunix
Copy link
Contributor

sunix commented Jun 25, 2020

+1 for workspace roots
it would be consistent to that proposal: #15347

@azatsarynnyy
Copy link
Member Author

All sub-tasks have been done.

@sunix
Copy link
Contributor

sunix commented Aug 26, 2020

Save Workspace As... - exports Che Workspace definition to Devfile #17239

why not just Export workspace definition to Devfile rather than Save Workspace As ... which is not clear ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants