Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for devfile kubernetes and openshift components #17894

Closed
sleshchenko opened this issue Sep 17, 2020 · 4 comments
Closed

Add support for devfile kubernetes and openshift components #17894

sleshchenko opened this issue Sep 17, 2020 · 4 comments
Labels
area/devworkspace-operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Milestone

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Sep 17, 2020

Is your enhancement related to a problem? Please describe.

Che currently ignores kubernetes and openshift components. These were previously supported by the che-server workspaces engine.

Describe the solution you'd like

  • Do not re-implement a che-server like behavior (i.e. extract the container of a pod/deployment and add it to the workspace pod): in the new implementation, an inner loop kubernetes or openshift component, would be applied without any modification.
  • This issue is not about the outer loop kubernetes and openshift components (there is a specific issue for that)
  • Block privileges escalations scenarios (i.e. if the user doesn’t have the privileges to create a pod in a given namespace, this feature should not allow him to do it)

Release Notes Text

Eclipse Che now supports devfile components of type kubernetes and openshift. That allow to reference Kubernetes and OpenShift manifests in a devfile and include them as part of the workspace. Devfile components of type volume and container were already supported, components of type image are not supported yet.

@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Sep 17, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 17, 2020
@sleshchenko sleshchenko added this to the 7.20 milestone Sep 17, 2020
@sleshchenko sleshchenko added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 18, 2020
@sleshchenko sleshchenko removed this from the 7.20 milestone Oct 1, 2020
@l0rd l0rd changed the title [devworkspace] Support k8s component Support for devfile v2 k8s components Sep 6, 2021
@l0rd l0rd removed this from the DevWorkspace Integration - STEP3 milestone Oct 4, 2021
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Feb 20, 2022
@l0rd l0rd changed the title Support for devfile v2 k8s components Support inner loop kubernetes and openshift components Feb 20, 2022
@ibuziuk ibuziuk mentioned this issue Feb 22, 2022
24 tasks
@ibuziuk ibuziuk mentioned this issue Mar 15, 2022
35 tasks
@ibuziuk ibuziuk mentioned this issue Apr 4, 2022
45 tasks
@Bolodya1997
Copy link

Bolodya1997 commented May 26, 2022

Is there any plan for implementing this feature?

In out project we want to create k8s Secret component with automount credentials annotation to add git credentials from the private Git repositories other than the devfile location.

Example:

components:
  - name: git-credentials-gitlab
    kubernetes:
      inlined: |
        {
          "kind": "Secret",
          "apiVersion": "v1",
          "metadata": {
            "name": "git-credentials-gitlab",
            "annotations": {
              "controller.devfile.io/mount-path": "/home/theia/.git-credentials"
            },
            "labels": {
              "controller.devfile.io/git-credential": "true",
              "controller.devfile.io/watch-secret": "true"
            }
          },
          "type": "Opaque",
          "data": {
            "credentials": "aHR0cDovL...b2NhbA=="
          }
        }

@che-bot
Copy link
Contributor

che-bot commented Nov 22, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2022
@che-bot che-bot closed this as completed Nov 29, 2022
@l0rd l0rd removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2023
@l0rd
Copy link
Contributor

l0rd commented Jan 12, 2023

This has been addressed by devfile/devworkspace-operator#961

@l0rd l0rd added this to the 7.59 milestone Jan 12, 2023
@l0rd l0rd changed the title Support inner loop kubernetes and openshift components Support devfile kubernetes and openshift components Jan 12, 2023
@l0rd l0rd changed the title Support devfile kubernetes and openshift components Add support for devfile kubernetes and openshift components Jan 12, 2023
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jan 12, 2023
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devworkspace-operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Projects
None yet
Development

No branches or pull requests

5 participants