chore: Update devfile API dependency to current main branch #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant devfile/api changes: * introduce autoBuild field on image components * introduce deployByDefault field on OpenShift and Kubernetes components * introduce annotations field on various objects to specify annotations for the kubernetes object to be created * add version for import references Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Adapt handling of additional annotations on the workspace Deployment to match what is expected from the devfile API (Annotations field on container components). As part of supporting this, removes support for specifying additional annotations/labels via attributes. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
approved these changes
Mar 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
kubernetesandopenshiftcomponents eclipse-che/che#17894A full diff between the previous and current devfile API dependencies is here.
What issues does this PR fix or reference?
Required for eclipse-che/che#17894
Is it tested? How?
.spec.template.components[].container.annotations.deploymentin a DevWorkspace and check that annotations are propagated to the workspace DeploymentPR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che