Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move devfile and plugin registry jobs to GitHub action #18072

Closed
ericwill opened this issue Oct 7, 2020 · 5 comments
Closed

Move devfile and plugin registry jobs to GitHub action #18072

ericwill opened this issue Oct 7, 2020 · 5 comments
Assignees
@ericwill
Labels
area/devfile-registry area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.25

Comments

@ericwill
Copy link
Contributor

ericwill commented Oct 7, 2020

Nightly

Currently there are nightly build jobs running for both the plugin registry and devfile registry. These can be moved to GH action instead of using centos-ci.

Relevant jobs:

  • devtools-che-plugin-registry-nightly
  • devtools-che-devfile-registry-nightly

Release

Both the plugin registry and devfile registry have release jobs on centos-ci as well. These could likely be moved to GH action, and can be triggered any time the VERSION file is changed.

Relevant jobs:

  • devtools-che-plugin-registry-release
  • devtools-che-devfile-registry-release

On the release side of things I'm not entirely sure how the centos-ci jobs were triggered, but I'd be willing to do the GH action replacement if @nickboldt / @mkuznyetsov if they can give me their use cases.
@ericwill ericwill added kind/task Internal things, technical debt, and to-do tasks to be performed. team/plugins area/devfile-registry area/plugin-registry labels Oct 7, 2020
@ericwill ericwill self-assigned this Oct 7, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 7, 2020
@ericwill ericwill removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 7, 2020
@ericwill ericwill added this to the 7.21 milestone Oct 7, 2020
This was referenced Oct 7, 2020
Closed
Merged
@benoitf
Copy link
Contributor

benoitf commented Oct 7, 2020

I think release jobs should be done 'on demand' without any git change.
It's now possible with GH action

@benoitf benoitf added severity/P2 Has a minor but important impact to the usage or development of the system. and removed team/plugins labels Oct 7, 2020
@ericwill
Copy link
Contributor Author

ericwill commented Oct 7, 2020

I think release jobs should be done 'on demand' without any git change.
It's now possible with GH action

Yes that works too. I was thinking only because the automated release PR bumps the VERSION file, so it could be based on that as well.

ericwill added a commit to eclipse-che/che-devfile-registry that referenced this issue Oct 8, 2020
@ericwill
Switch nightly build to GH action (#290)
7aab440 
* Switch nightly build to GH action

Run a GitHub action job everytime a change is merged, instead of using centos-ci.

See eclipse-che/che#18072

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Update secret name

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Make action names more clear

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Abstract centos-ci only steps

Only use provided scripts for:
* base image build + push
* happy path image build + push

Signed-off-by: Eric Williams <ericwill@redhat.com>
monaka pushed a commit to PizzaFactory/che-devfile-registry that referenced this issue Oct 11, 2020
@ericwill @monaka
Switch nightly build to GH action (eclipse-che#290)
6c1597f 
* Switch nightly build to GH action

Run a GitHub action job everytime a change is merged, instead of using centos-ci.

See eclipse-che/che#18072

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Update secret name

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Make action names more clear

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Abstract centos-ci only steps

Only use provided scripts for:
* base image build + push
* happy path image build + push

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Oct 21, 2020
Merged
9 tasks
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Oct 21, 2020
@ericwill
Switch nightly job to GitHub action (#653)
5cdfa8f 
See eclipse-che/che#18072

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Oct 22, 2020
Closed
29 tasks
@ericwill ericwill modified the milestones: 7.21, 7.22 Nov 2, 2020
@ericwill ericwill modified the milestones: 7.22, 7.23 Nov 12, 2020
@ericwill ericwill mentioned this issue Nov 12, 2020
Closed
34 tasks
@benoitf
Copy link
Contributor

benoitf commented Nov 26, 2020

@ericwill can be closed no ?

@ericwill ericwill mentioned this issue Nov 26, 2020
Merged
9 tasks
@ericwill
Copy link
Contributor Author

@ericwill can be closed no ?

No, there are still the release jobs that need to be migrated (happening this sprint).

@ericwill ericwill mentioned this issue Dec 1, 2020
Merged
9 tasks
@ericwill ericwill modified the milestones: 7.23, 7.24 Dec 8, 2020
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Dec 11, 2020
@ericwill
Add a GitHub action based release job (#723)
2867bf3 
* Add a GitHub action based release job

Part of eclipse-che/che#18072

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Use release branch push based approach

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Update file and job names

Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill added a commit to eclipse-che/che-devfile-registry that referenced this issue Dec 11, 2020
@ericwill
Add a GitHub action based release job (#309)
0093cdb 
* Add a GitHub action based release job

Part of eclipse-che/che#18072

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Add dockerhub login step

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Update file and job name

Signed-off-by: Eric Williams <ericwill@redhat.com>
@nickboldt nickboldt modified the milestones: 7.24, 7.25 Jan 8, 2021
@nickboldt
Copy link
Contributor

Given we used the new GH actions for 7.24, I suspect we can close this.

https://github.com/eclipse/che-devfile-registry/actions?query=workflow%3A%22Release+Che+Devfile+Registry%22 (7.24.0 - 7.24.2)

https://github.com/eclipse/che-plugin-registry/actions?query=workflow%3A%22Release+Che+Plugin+Registry%22 (7.24 and 7.24.1 only so far)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwill ericwill

Labels
area/devfile-registry area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.25
Development

No branches or pull requests
4 participants
@nickboldt @benoitf @ericwill @che-bot