Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DevWorkspaceRouting a pre-requisite of che-operator #20088

Closed
metlos opened this issue Jul 7, 2021 · 3 comments
Closed

Make DevWorkspaceRouting a pre-requisite of che-operator #20088

metlos opened this issue Jul 7, 2021 · 3 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@metlos
Copy link
Contributor

metlos commented Jul 7, 2021

Is your task related to a problem? Please describe.

Currently, we have che-operator (CO) and devworkpace che operator (DWCO) running as separate containers in a single pod. In addition to other responsibilities, CO is in charge of enabling the support for Devworkspaces. This includes the installation of all the necessary CRDs (i.e. DevWorkspace, DevWorkspaceTemplate, DevWorkspaceRouting and possibly others, depending on what DWO declares).

DWCO requires CheCluster and DevWorkspaceRouting for its operation.

In order to be able to run DWCO and CO as a single executable, we need DevWorkspaceRouting pre-installed in the cluster.

Describe the solution you'd like

Pre-install the DevWorkspaceRouting CRD (defined in the DWO codebase) before installing the che-operator.

Describe alternatives you've considered

We can also keep the codebases separate and co-deploy the CO and DWCO containers in the operator pod as is done at the moment (doing that enables us to wait until all the CRDs are available before starting the controller manager in DWCO).

@metlos metlos added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 7, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 7, 2021
@metlos
Copy link
Contributor Author

metlos commented Jul 7, 2021

@l0rd what do you prefer?

  1. Merging the codebases makes the life easier for future development and removes 1 image from our deliverables, but requires part of the "devworkspace ecosystem" be preinstalled even if devworkspaces are disabled.
  2. Keep the CO and DWCO codebases separate (2 deliverables instead of one, slightly more complex dependency structure) but be able to "flip on and off" devworkspaces completely.

Note that currently, we use the option 2.

@l0rd
Copy link
Contributor

l0rd commented Jul 7, 2021

@metlos 👍 for option 1

@flacatus flacatus added severity/P1 Has a major impact to usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 8, 2021
@metlos
Copy link
Contributor Author

metlos commented Jul 13, 2021

The DWR CRD cannot be pre-installed the way we imagined in this issue.

@metlos metlos closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants