Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (Un)install DevWorkspaceRouting CRD during during (un)installation using operator. #1393

Closed
wants to merge 1 commit into from

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jul 8, 2021

What does this PR do?

This creates the DevWorkspaceRouting CRD during the installation with che-operator and uninstalls
it when deleting the cluster.

DevWorkspaceRouting will become a prerequisite of che-operator once the devworkspace-che-operator is merged into the che-operator codebase.

Note that this PR depends on eclipse-che/che-operator#894.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20088

How to test this PR?

  1. chectl server:deploy -a operator
  2. kubectl get crds | grep devworkspaceroutings

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: metlos

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos metlos force-pushed the bug/20088-dwr-as-prereq branch from 5a0541c to c7166f0 Compare July 8, 2021 12:52
…ion using operator.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@metlos metlos force-pushed the bug/20088-dwr-as-prereq branch from c7166f0 to 62c5992 Compare July 8, 2021 12:59
@tolusha
Copy link
Collaborator

tolusha commented Jul 8, 2021

Sounds good.
Pls find update tasks and add changes there as well.

https://github.com/che-incubator/chectl/blob/main/src/tasks/installers/operator.ts#L321

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

@metlos: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v7-chectl-e2e-operator-installer 62c5992 link /test v7-chectl-e2e-operator-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@metlos
Copy link
Contributor Author

metlos commented Jul 12, 2021

I'm closing this in favor of a design where che-operator will be still in charge of the installation of DWR and will have alternative watch sets based on the CRD presence in the cluster, as discussed with @sleshchenko.

@metlos metlos closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants