Workspace fails to start when VS Code is the editor and the git repository has no devfile

[l0rd]

Describe the bug

If a Git repository hasn't a devfile at its root and VS Code is the editor the workspace creation fails with this error:

Che version

next (development version)

Steps to reproduce

On the dogfooding instance (because VS Code is the default editor there), in the Create Workspace page put the URL of a Git repo that doesn't have a Devfile in the Git repo URL (I reproduced it with https://github.com/devfile/developer-images that doesn't have a devfile yet)

On any other Che instance use a factory URL using a Git repo that doesn't have a Devfile and the parameter che-editor=che-incubator/che-code/insiders

Expected behavior

The workspace should be started using a default devfile component as mentioned in this issue and in particular here.

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub, other (please specify in additional context)

Environment

Amazon

Eclipse Che Logs

No response

Additional context

No response

[ibuziuk]

@l0rd @nickboldt @tolusha my suggestion for fixing this issue would be to set the default value for default components on the operator level e.g.

devEnvironments:
    defaultComponents:
      - container:
          image: 'quay.io/devfile/universal-developer-image:ubi8-latest'
          sourceMapping: /projects
        name: universal-developer-image

this is the config we apply to the dogfooding instance. The question is what image should we use for the Dev Spaces product taking into account that the airgap flow needs to be supported

[l0rd]

@ibuziuk how is your proposal different from one in the "Expected behavior" section in this issue description? And I would rather use a fixed hash, not latest. The image should match the one used in our samples (all the samples use the same image). For Dev Spaces we currently have 3 UDI images for the samples, we should probably use the java one. cc @nickboldt

[ibuziuk]

Fixed in eclipse-che/che-operator#1486
Closing

[max-cx]

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3416