Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code ignores the --port parameter passed to the launch script #21711

Closed
azatsarynnyy opened this issue Sep 16, 2022 · 3 comments · Fixed by che-incubator/che-code#110
Closed

VS Code ignores the --port parameter passed to the launch script #21711

azatsarynnyy opened this issue Sep 16, 2022 · 3 comments · Fixed by che-incubator/che-code#110
Assignees
@azatsarynnyy
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.54

Comments

@azatsarynnyy
Copy link
Member

Describe the bug

VS Code stopped taking into account the --port parameter on its launch.

https://github.com/che-incubator/che-code/blob/b1768011994575e92bfaa767c5c990cc95837eca/build/scripts/entrypoint-volume.sh#L76

Despite the specified 3100, it's launching on 8000.

Che version

next (development version)

Steps to reproduce

Run a DevWorkspace with VS Code editor image build from the main branch.

Expected behavior

VS Code must respect the --port parameter.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/latest

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response
@azatsarynnyy azatsarynnyy added kind/bug Outline of a bug - must adhere to the bug report template. sprint/next severity/P1 Has a major impact to usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Sep 16, 2022
@azatsarynnyy
Copy link
Member Author

The suspicious commit: microsoft/vscode@519b06e

@azatsarynnyy
Copy link
Member Author

Florent's comment:

executing command socat tcp-l:3100,fork,reuseaddr tcp:127.0.0.1:8000 in the terminal of UDI for example allows to boot the workspace

This was referenced Sep 16, 2022
Closed
Merged
@azatsarynnyy
Copy link
Member Author

It turned out to be an upstream bug. See microsoft/vscode#160094 (comment) for more details.

@azatsarynnyy azatsarynnyy mentioned this issue Sep 19, 2022
Closed
82 tasks
@azatsarynnyy azatsarynnyy added this to the 7.54 milestone Sep 19, 2022
@azatsarynnyy azatsarynnyy self-assigned this Sep 19, 2022
@azatsarynnyy azatsarynnyy mentioned this issue Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.54
Development

Successfully merging a pull request may close this issue.

fix: server-main.js should respect the --port argument che-incubator/che-code
1 participant
@azatsarynnyy