Clean up server-main.js #160094
Merged
Clean up server-main.js #160094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexdima Check out my fix for storing the |
alexdima
approved these changes
Sep 15, 2022
|
Hello @aeschli @alexdima Could you please take a look at it? |
This was referenced Sep 19, 2022
|
Thanks a lot for finding this @azatsarynnyy. I created #161314 with the fix. |
|
Oh, you already made a PR, thanks! |
aeschli
pushed a commit
that referenced
this pull request
Sep 20, 2022
After #160094 merged, `server-main.js` ignores the `--port` argument. This patch fixes the problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160015
Removes
--pick-port. Deprecated for a year and I checked that the remote extension sdon't use it anymore.