-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE_SERVER_CONTAINER_NAME doesn't have any effect. #2187
Comments
This variable |
@TylerJewell nah - still doesn't seem to work in 4.7. |
I pulled latest 4.7 release, then launched Che like this:
But docker ps output is this:
Seems like CHE_SERVER_CONTAINER_NAME didn't work. |
You don't have the right image :). Your image is still 4.6 for the che-launcher. Try CHE_VERSION=4.7 or CHE_VERSION=nightly |
I can tell that it is 4.5 launcher as the letters are all caps. We changed it so I know your image is out of date. |
@TylerJewell thx.
|
Tag is 4.7.0 |
4.7 was shipped a couple hours ago, so yes it should be there. The tag is 4.7.0, latest. If you already have a latest tag, however, you must delete the latest image and then pull it again. Maybe we should add a feature in the "update" CLI where if you do "che update --force", we will delete teh image and redownload it to verify you have the latest. |
@benoitf ahh yes yes - it worked when I changed label to 4.7.0. Thx! |
@riuvshin - can we consider tagging 4.7.0 and 4.7 at the same time? I think this will be a common thing. |
@TylerJewell no we have different versioning, there could be bugfixes like 4.7.1 4.7.2 which is not compatible with 4 or 4.7 versioning models. I would say just use |
@riuvshin it is compatible as 4.7 will be updated to 4.7.1 if there is a new 4.7.x this is how all base dockerhub images are working |
Roman - yes please consider what florent is suggesting. |
When starting eclipse che Im using
CHE_SERVER_CONTAINER_NAME
environmental variable.ex:
-e CHE_SERVER_CONTAINER_NAME="che_jcarter"
My understanding of how it's supposed to work -> is that after che container boots it would have a name
che_jcarter
.However this doesn't seem to work. After booting che container has a name = che-server:
The text was updated successfully, but these errors were encountered: