-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support che-in-che #2119
Conversation
Build # 90 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/90/ to view the results. |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/92/ |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/100/ |
@eivantsov @benoitf @riuvshin - can you please test the new capabilities related to the che profile on Ubuntu? Sequence for users would be the following.
@eivantsov - one action would be to update the ARTIK Vagrant file to use this latest Che CLI. User can set CHE_ environment variables to define the name of the image and the name of the container that will be created. |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/102/ |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/111/ |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/112/ |
Build # 125 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/125/ to view the results. |
Build # 145 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/145/ to view the results. |
+1 |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/176/ |
echo "CHE_TEST_CONTAINER_NAME=$CHE_TEST_CONTAINER_NAME" >> ~/.che/"${3}" | ||
|
||
env | grep CHE_ >> "${3}" | ||
cat ~/.che/"${3}" | sort | uniq > ~/.che/"${3}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to use intermediate file like in add section
I'm eager to have it in master 👍 |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/191/ |
* Che server container editable * Add CHE_WORKSPACE_STORAGE variable * stack and template * fixed echo bug * Added profiler * Fix CHE_DATA_FOLDER issues * Add additional variables to be honored * ordering * Fix profile add * Revert change to ExtraVolumeProvider * fixed profile update
Motivation
There are a variety of things that we need to add to simplify running Che within a Che workspace for new users. The full description of the use case is located in #2116.
What does this PR do?
Adds in capabilities to make it easier to run che-in-che scenarios.
1: Improved the
che-launcher
andche.sh
scripts so that the name of the che-server container can be defined by an environment property. This will allow workspaces starting a second che-server to change the name so that it does not conflict with the one that is already running.2: Added
CHE_WORKSPACE_VOLUME
environment variable that lets user set an extra volume to be mounted into Che workspaces when they are started. Also introducesche.workspace.volume
property and uses that value instead ofmachine.server.extra.volume
property.3: Adds a new ready-to-go stack that lists the components that are part of the new Che recipe and launches that container.
4: Adds a new template mapped to the Che stack, that will clone the che repo and add a series of commands to build / run che within Che.
5: Adds fix for Ubuntu where
--env-file
was getting misinterpreted by echo as -e flag.6: Adds fix to handle Windows directories with spaces in the names for the mount path conversion.
7: Adds enhancement to provide new profile capability into the CLI. Profile capability lets user store the values of current environment variables into a profile that will be loaded and used by the che-launcher. This allows users to save multiple Che configurations and switch between them.
8: Added fix for CHE_LOCAL_BINARY on boot2docker systems.
9: Added fix for CHE_DATA_FOLDER on boot2docker systems. Before we were only adding in the new CHE_WORSKPACE_STORAGE_CREATE_FOLDERS if it was docker for windows or mac, but this generally needed on all systems now.
10: Adds additional environment variables which can be end user configurable and stored within a Che profile. The benefit of setting these values is that you can have different profiles with different names for CHE_SERVER_CONTAINER name which lets you run multiple Che servers at the same time without the container names conflicting. Also, this allows us to support assemblies like the ARTIK IDE by letting them reuse the launcher and the CLI just changing a profile to get it to work.