-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor does not filter code completion proposals from language server #2592
Comments
Not sure it is bug on client side looks like LS should give as already filtered result. We will take a look |
This is how it works in VS Code. The JSON language server make only context-based filtering. Then it leaves the client to decide how to execute the filtering based on the user input: using startWith, substring or fuzzy matching strategy. This is why the LSP defines the Of course, the language server can decide to implement the text-input filtering itself, but this is not strictly defined by the protocol. Even if the server does it, there is no drawback if the client does it once again - e.g. for displaying the highlighting in the completion proposal window. BTW, I am almost done on a PR based on the FuzzyMatcher used for the GoToSymbolAction. |
…e server Implements filtering based on the existing FuzzyMatches used for the GoToSymbolAction.
…e server Implements filtering based on the existing FuzzyMatches used for the GoToSymbolAction. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
…e server (eclipse-che#2658) * Fixes eclipse-che#2592: Filter code completion proposals from language server Implements filtering based on the existing FuzzyMatches used for the GoToSymbolAction. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com> * Add empty line at end of file.
As visible on the below screenshot, the editor does not filter the completion proposals retrieved from the language server. I would expect to have only the "name" item in the list, but I get a lot more.
While for JSON files the completion proposal list is relatively short, for programming language like Java, PHP and others it can be exhaustive. Lack of filtering would make the code completion feature unusable.
Note that the issue is not specific to the JSON editor, but for any editor using a language server (see #1287).
Reproduction Steps:
composer.json
file.Expected behavior:
The list of completion items is filtered in the editor.
Observed behavior:
The list of completion items is not filtered at all.
Che version: build from PR #2474
OS and version: Fedora 24
Docker version: 1.10.3
Che install: local build, started with the
bin/che.sh
scriptAdditional information:
The text was updated successfully, but these errors were encountered: