Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a duplicate commands goal in a project context menu after changing a command settings #4940

Closed
SkorikSergey opened this issue Apr 27, 2017 · 3 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@SkorikSergey
Copy link
Contributor

SkorikSergey commented Apr 27, 2017

Reproduction Steps:
From the Commands Explorer in one of goal(for example "Run") create at least two command.
Do some change for one command and click Save button.

Observed behavior:
In Commands context menu are two "Run" goals.

OS and version:
Che(Che6 branch) 6.0.0-M5; Chrome 63.0; Fedora 25
anim

@ghost ghost added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. labels Apr 27, 2017
@ghost
Copy link

ghost commented Jul 12, 2017

Reproduced in 5.15-SNAPSHOT

@ghost ghost added the team/ide label Jul 12, 2017
@SkorikSergey
Copy link
Contributor Author

teams-11-5

@SkorikSergey
Copy link
Contributor Author

This issue is actual for Che 6.11.0-SNAPSHOT.

@vzhukovs vzhukovs self-assigned this Oct 24, 2018
vzhukovs added a commit that referenced this issue Nov 5, 2018
…rmation (#11745)

### What does this PR do?
This changes proposal adds few fix related to edit command name. First fix prevent saving command name with trailing whitespaces. Second fix adds backward compatibility to allow char `:` in command names. Third fix prevent command duplication after update operation.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

### What issues does this PR fix or reference?
#4940 
<!-- #### Changelog -->
<!-- The changelog will be pulled from the PR's title. 
     Please provide a clear and meaningful title to the PR and don't include issue number -->


#### Release Notes
<!-- markdown to be included in marketing announcement - N/A for bugs -->


#### Docs PR
<!-- Please add a matching PR to [the docs repo](https://github.com/eclipse/che-docs) and link that PR to this issue.
Both will be merged at the same time. -->
@vzhukovs vzhukovs added this to the 6.14.0 milestone Nov 5, 2018
@vzhukovs vzhukovs closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants