Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for EditorConfig #7588

Closed
gorkem opened this issue Nov 28, 2017 · 7 comments
Closed

Support for EditorConfig #7588

gorkem opened this issue Nov 28, 2017 · 7 comments
Assignees
@vitaliy-guliy
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@gorkem
Copy link
Contributor

gorkem commented Nov 28, 2017

Description

We should support the EditorConfig to define coding styles and honor .editorconfig files that exists on a project.
@gorkem gorkem added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels Nov 28, 2017
@AndrienkoAleksandr
Copy link
Contributor

Seems related #7559

@skabashnyuk
Copy link
Contributor

Probably related to #8266 because of this #5330

@skabashnyuk
Copy link
Contributor

@ashumilova @evidolob please take a look at this issue. wdyt how it can be related to Theia IDE?

@ashumilova ashumilova mentioned this issue Mar 13, 2018
Closed
12 tasks
@ashumilova ashumilova added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 22, 2018
@ashumilova ashumilova mentioned this issue Mar 23, 2018
Closed
17 tasks
@vitaliy-guliy
Copy link
Contributor

Left to do:

  • handle charset, trim_trailing_whitespace and insert_final_newline properties
  • listen changing of .editorconfig file and update configuration of opened editors
  • write tests for the plugin using jest

@vitaliy-guliy
Copy link
Contributor

Work is done.
Editorconfig extension in separate branch on Theia repository.
https://github.com/theia-ide/theia/tree/editorconfig

@vitaliy-guliy
Copy link
Contributor

An issue with discussion on Theia repository
eclipse-theia/theia#1694

@vitaliy-guliy vitaliy-guliy added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 16, 2018
@vitaliy-guliy
Copy link
Contributor

PR with the extension
eclipse-theia/theia#1708

@vitaliy-guliy vitaliy-guliy removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliy-guliy vitaliy-guliy

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gorkem @ashumilova @skabashnyuk @vitaliy-guliy @AndrienkoAleksandr