Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for EditorConfig #1694

Closed
vitaliy-guliy opened this issue Apr 13, 2018 · 3 comments
Closed

Support for EditorConfig #1694

vitaliy-guliy opened this issue Apr 13, 2018 · 3 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Apr 13, 2018

Add an extension supporting EditorConfig to define coding styles.

Working on extension is in branch
https://github.com/theia-ide/theia/tree/editorconfig

@akosyakov akosyakov added the enhancement issues that are enhancements to current functionality - nice to haves label Apr 13, 2018
@akosyakov
Copy link
Member

How is it going to be integrated with the current preferences?

VS code extension overrides configurations user/workspace editor settings. Would not it make sense in our case as well?

@vitaliy-guliy
Copy link
Contributor Author

We also override editor configuration. Editorconfig has bigger priority than editor preferences.

@akosyakov
Copy link
Member

akosyakov commented Apr 13, 2018

I meant we should consider whether we want to make sure that the preferences API returns consistent results with what users see in editors. If so then we should hook it up in the preferences machinery.

cc @svenefftinge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

No branches or pull requests

2 participants